143783 - Splash screen should catch mouse button events

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Stephane Chauveau]

On X11, the splash screen redirects all mouse buttons events to 
the background. For example, on my system (linux & sawfish window
manager), a left click on the splash screen opens the windows
list popup. 

I propose to close the splash screen when a mouse button event
is catched (the gnome desktop splash screen works like that). 

build: Linux 2002050921 (also tested on HPUX11)

Comment 1

[Matthias Versen [:Matti]]

I don't think that we close the splash screen if you click with the mouse.

You can disable it if you use "mozilla -nosplash"

Is that enough ?

Comment 2

[Stephane Chauveau]

Not really! The problem is to disable the splash screen (in fact on Linux the
default is without a splash screen). 

Clicking on the splash screen SHOULD NOT OPEN A NON-MOZILLA MENU. 

Closing the spash screen was just a possible enhancement (I could have 
filled a separate bug for that).

Comment 3

[Matthias Versen [:Matti]]

-> XP APPS

Comment 4

[Kai Lahmann (is there, where MNG is)]

works for me. Can you reproduce this with a recent Mozilla version like 1.1beta?

Comment 5

[Stephane Chauveau]

I am now using fvwm2 and the problem is still there with 
2002081104 (Linux). Clicking on the splash screen opens 
the background menu of fwmw2

Which window manager/desktop are you using?

Comment 6

[Kai Lahmann (is there, where MNG is)]

KDE 3.0.2

Comment 7

[Stephane Chauveau]

I do not have it installed so I can't test it.
However, I wouldn't be surprised if the KDE was
handling background events like Gnome/Nautilus 
by inserting a fullscreen window below any other 
windows (but on top of the root window). In that 
case, splash events directly passed to the root 
window would not trigger any effects.

Can you try with a simple wm (twm,fvwm,...)?

I also noticed that the splash window is not 
configured to process or intercept (not 
propagate) mouse button events:

# chauveau@simak:~$ xwininfo -events
#
#xwininfo: Please select the window about which you
#          would like information by clicking the
#          mouse in that window.
#
#xwininfo: Window id: 0x800005 "<unknown>"
#
#  Someone wants these events:
#      StructureNotify
#      FocusChange
#  Do not propagate these events:
#  Override redirection?: Yes
#

Compare that with how a typical application 
such as xclock handles button events.

#xwininfo: Please select the window about which you
#          would like information by clicking the
#          mouse in that window.
#
#xwininfo: Window id: 0x1200009 "xclock"
#
#  Someone wants these events:
#      EnterWindow
#      LeaveWindow
#      StructureNotify
#      FocusChange
#      PropertyChange
#      ColormapChange
#  Do not propagate these events:
#      ButtonPress
#      ButtonRelease
#  Override redirection?: No

Comment 8

[Kenneth Herron]

I can reproduce this with build ID 20030315 for linux with either gtk or gtk2. I
can't reproduce it under KDE and I don't have fvwm2 on my system, but when I run
"mozilla -splash" under icewm, right-clicking on the splash displays the icewm menu.

Comment 9

[Kenneth Herron]

Attachment: Make the splash window receive button events.

This patch makes the splash screen receive button presses and releases. When
run under ICEWM, it prevents the wm menu from appearing. I haven't seen any
adverse effects under KDE.

Comment 10

[Christopher Blizzard (:blizzard)]

Comment on attachment 117357 [details] [diff] [review]
Make the splash window receive button events.

sr=blizzard

Comment 11

[Andreas Kunz]

Kenneth Herron, your patch has r= ad sr= but was not checked in as I see from
http://lxr.mozilla.org/seamonkey/source/xpfe/bootstrap/nsNativeAppSupportGtk.cpp#108

If this is still an issue, would you mind testing if this patch still does the
right thing and let us know that it should be checked in?
(I have no Linux to test it)

Comment 12

[Kenneth Herron]

I didn't try to reproduce the problem--it doesn't appear under kde as I noted
before--but I have no reason to believe it has disappeared. I ran cvs builds
with the patch installed for several months last year with no ill effect. The
patch still applies cleanly.

After getting r/sr on the patch I was never able to find someone to check it in
for me. If you can get it checked in, then please do.

Comment 13

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in xpfe/bootstrap/nsNativeAppSupportGtk.cpp;
/cvsroot/mozilla/xpfe/bootstrap/nsNativeAppSupportGtk.cpp,v  <-- 
nsNativeAppSupportGtk.cpp
new revision: 1.16; previous revision: 1.15
done