144309 - STAN_GetCERTCertificate return value not checked

Status: VERIFIED FIXED

(NSS :: Libraries, defect, P2)

Description

[Julien Pierre]

In many parts of stanpcertdb.c , the returned CERTCertificate pointer is not 
checked. It can be NULL, for example for newly-decoded certificates.

Comment 1

[Julien Pierre]

Attachment: Fix to check for return value and avoid crashes

Comment 2

[Wan-Teh Chang]

Assigned the bug to Ian.

Comment 3

[Ian McGreer]

Attachment: handle NULL rv's from all STAN_GetCERTCertificate calls

This patch expands on the last one, to find all places where return from
STAN_GetCERTCertificate can return NULL.  As Julien noted, that can occur if
the encoding was somehow invalid, or if CERT_DecodeDERCertificate failed for
some other reason.

This patch is somewhat paranoid.  The most important change is in pkibase.c,
where cert_CreateObject returns NULL if STAN_GetCERTCertificate fails.	At that
point, even the NSSCertificate is destroyed, and it disappears from the system.
 So in reality, hitting failure cases anywhere else should not happen.	But I
decided to be strict anyway.

Comment 4

[Wan-Teh Chang]

Comment on attachment 83794 [details] [diff] [review]
handle NULL rv's from all STAN_GetCERTCertificate calls

r=wtc.

Comment 5

[Ian McGreer]

checked into NSS_3_5_BRANCH and tip.

Comment 6

[Jaime Rodriguez, Jr.]

adt1.0.1+ (on ADT's behalf) for checkin to the 1.0 branch. Pls check this in
asap. thanks! 

Comment 7

[Charles Rosendahl]

Verified in the latest branch code.  The patch is intact.