145375 - Update Google sherlock file to support Unicode

Status: VERIFIED FIXED

(SeaMonkey :: Search, defect, P3)

Description

[bobj]

The sherlock file for Google should be modified to support Unicode, then
we can search in any language and receive and display multilingual results.

We need to add the specification for 
 - the query charset
 - the Google input and output encodings
 - the interpret charset for the results

Here are the diffs for SBWeb_02.src

@@ -9,15 +9,19 @@
    update= "http://search.netscape.com/sherlock/SBWeb_02.src" 
    updateIcon= "http://search.netscape.com/sherlock/SBWeb_02.gif" 
    updateCheckDays= 1   
+   queryCharset="UTF-8"
 >
 
 <input name="q" user>
 <input name="sourceid" value="mozilla-search">
 <inputnext name="start" factor="10">
 <inputprev name="start" factor="10">
+<input name="ie" value="utf-8">
+<input name="oe" value="utf-8">
 
 <interpret 
     browserResultType="result" 
+    charset = "UTF-8"
     resultListStart="<!--a-->" 
     resultListEnd="<!--z-->" 
     resultItemStart="<!--m-->" 

I'm not sure if the inputprev and inputnext are really needed.  Can
those lines be deleted.

The results in the browser window displays fine, but there appears to be
a problem in the sidebar search tab to correctly display characters not
in the "system" charset.

Comment 1

[Gashu]

Google Sharlock Plugin in google.com is now updated with UTF-8 support.
http://www.google.com/mozilla/google.src

But 1.0.1rc1 doesn't include this updated google.src yet.

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

We should try to get this in 1.0.2

Comment 3

[Erich 'Ricky' Iseli]

*** Bug 161181 has been marked as a duplicate of this bug. ***

Comment 4

[Erich 'Ricky' Iseli]

*** Bug 143315 has been marked as a duplicate of this bug. ***

Comment 5

[Erich 'Ricky' Iseli]

*** Bug 144786 has been marked as a duplicate of this bug. ***

Comment 6

[Erich 'Ricky' Iseli]

*** Bug 170129 has been marked as a duplicate of this bug. ***

Comment 7

[Gashu]

Just in the case: how will it go on trunk and Phoenix?
http://www.google.com/mozilla/google.src
Anyway, newer one is better for all...

Comment 8

[bjoern]

is there nobody willing to fix this bug? It really ain't that difficult to
update that file, is it?

Comment 9

[James Kilfiger]

Nominating for 1.4
This is the sort of high profile bug that makes mozilla look bad to
international users. This bug bites me nearly everyday. 

Comment 10

[Gashu]

I *strongly* stand by comment 9.
for both Mozilla (Seamonkey) and Mozilla Firebird.
And Moz1.0.2 is now gone from toppage of mozilla.org and this wish/bug is still
opened.

As I pointed at comment 7, definitely new one is BETTER.

Comment 11

[Roland Mainz]

roc+moz:
Any idea why noone is working on this ?

Comment 12

[Benjamin Smedberg]

Attachment: http://www.google.com/mozilla/google.src

This is the google.src currently at http://www.google.com/mozilla/google.src

Attaching this so I can set flags.

Comment 13

[(not reading, please use [e-mail] instead)]

does this just need to update
http://lxr.mozilla.org/mozilla/source/xpfe/components/search/datasets/google.src?

Comment 14

[Benjamin Smedberg]

sspitzer: yes. We are only updating our shipped version to match Google's
supplied version.

Comment 15

[Asa Dotzler [:asa]]

Comment on attachment 123149 [details]
http://www.google.com/mozilla/google.src

a=asa (on behalf of drivers) for checkin to 1.4. Is someone going to make a
real patch and check something in?

Comment 16

[(not reading, please use [e-mail] instead)]

re-assign to jag, who says he can test this (verify it is ok), and then will
check in.

Comment 17

[jag (Peter Annema)]

Attachment: The patch, for reference.

Comment 18

[jag (Peter Annema)]

Checked in.

Comment 19

[jag (Peter Annema)]

Comment on attachment 123194 [details] [diff] [review]
The patch, for reference.

r=me, sr=sspitzer, a=Asa

Comment 20

[Erich 'Ricky' Iseli]

*** Bug 205585 has been marked as a duplicate of this bug. ***

Comment 21

[Asa Dotzler [:asa]]

*** Bug 199294 has been marked as a duplicate of this bug. ***

Comment 22

[Mycroft Project (CC)]

*** Bug 56017 has been marked as a duplicate of this bug. ***

Comment 23

[Mycroft Project (CC)]

*** Bug 246261 has been marked as a duplicate of this bug. ***