Closed
Bug 146020
Opened 23 years ago
Closed 22 years ago
javascript strict warnings in search-panel.js
Categories
(SeaMonkey :: Search, defect)
SeaMonkey
Search
Tracking
(Not tracked)
RESOLVED
FIXED
Future
People
(Reporter: bugzilla, Assigned: samir_bugzilla)
Details
(Keywords: qawanted)
Attachments
(1 file)
|
514 bytes,
patch
|
shliang
:
review+
alecf
:
superreview+
|
Details | Diff | Splinter Review |
when using the search panel i the sidebar:
Warning: function doSearch does not always return a value
Source File: chrome://communicator/content/search/search-panel.js
Line: 682
Source Code:
}
20020521
|
Assignee | |
Comment 1•23 years ago
|
||
Steps to reproduce? Build ID?
Keywords: qawanted
Target Milestone: --- → Future
|
Reporter | |
Comment 2•23 years ago
|
||
to reproduce:
1. turn on sidebar
2. click on the search sidebar
then you get the warning in the js console
|
|
||
Comment 3•23 years ago
|
||
doSearch returns the result of onNavWindowLoad in one path through the code.
However, onNavWindowLoad does not return any value, so the return is bogus.
This patch removes the return and uses an if/else to more clearly show the
logic.
|
|
||
Updated•23 years ago
|
|
|
||
Updated•22 years ago
|
Attachment #104433 -
Flags: review?
Attachment #104433 -
Flags: review? → review?(shliang)
Attachment #104433 -
Flags: review?(shliang) → review+
|
|
||
Updated•22 years ago
|
Attachment #104433 -
Flags: superreview?(alecf)
|
|
||
Comment 4•22 years ago
|
||
Comment on attachment 104433 [details] [diff] [review]
Patch to get rid of the warning in doSearch
sr=alecf
Attachment #104433 -
Flags: superreview?(alecf) → superreview+
|
|
||
Comment 5•22 years ago
|
||
Could someone check this in for me? I don't have cvs access.
|
|
||
Comment 6•22 years ago
|
||
This has been checked in.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
|
||
Updated•17 years ago
|
Product: Core → SeaMonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•