146074 - Proxy-authorization not on all requests after authentication

Status: VERIFIED FIXED

(Core :: Networking: HTTP, defect, P2)

Description

[Dan Mellem]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.0rc2)
Gecko/20020510
BuildID:    2002051006

After authenticating to the proxy server, all GET, PUT, and POST requests should
have the Proxy-authorization: entry in the header. However, it is not offered
until it receives a 407 (Proxy Authentication Required) response from the proxy.

This can cause some items to not load properly when using Squid. This may be the
cause of bug 140038 since it tends to cause "Connection refused" and "Document
contains no data" errors.

Reproducible: Always
Steps to Reproduce:
1. Configure web browser to use a proxy server that requires authentication (I'm
using a PAC file).
2. Capture packets...
3. Load a page that has several images or other objects.
4. View capture.

Actual Results:  Each new connection to the proxy does not have the
Proxy-authentication: header, causing a 407 error and an error page downloaded.
The request is then tried again. Usually the second request will have the
authentication information but sometimes three or more requests are sent without
authentication.

Expected Results:  Each new connection to a proxy server that has already been
authenticated to should automatically offer the authentication information.
Direct connections (via .PAC) and other proxy servers would not be sent the
authentication information.

Similar to bug 140773 but that bug says the authentication is only sent the
first time; I'm discovering that it's only sent AFTER the first time so it may
be a different problem.

Comment 1

[Darin Fisher]

this is a major regression... thanks for pointing it out.  investigating...

Comment 2

[Darin Fisher]

Attachment: v1 patch

simple fix

Comment 3

[Tom Everingham]

*** Bug 140773 has been marked as a duplicate of this bug. ***

Comment 4

[rpotts (gone)]

hey darin,

isn't the following code...

+        // path's can be empty (even NULL)
+        if (!path || !*path) {
+            if (!entryPath || !*entryPath) {
                 *result = entry;
                 break;

really just,

         if (!path && !entryPath) {
             *result = entry;
             break;
         }

it's not a big deal, but the double if is kinda mind-bending :-)

-- rick

Comment 5

[rpotts (gone)]

oops.. ignore my last post :-)  i was misreading the patch :-(

-- rick

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

Darin - should that be strncasecmp instead of strncmp?

Comment 7

[rpotts (gone)]

Comment on attachment 84563 [details] [diff] [review]
v1 patch

sr=[e-mail]

Comment 8

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 84563 [details] [diff] [review]
v1 patch

r=[e-mail] under the assumption that the URLs in the entries and passed
in are case-normalized already.

Comment 9

[Randell Jesup [:jesup] (needinfo me)]

Darin - let's get this into trunk and go for approval

Comment 10

[Darin Fisher]

rjesup: http URL paths are case sensitive, so strncmp is correct.  thx for the
review.

Comment 11

[Darin Fisher]

fixed-on-trunk

Comment 12

[chris hofmann]

Comment on attachment 84563 [details] [diff] [review]
v1 patch

a=chofmann,jesup,shaver. 
need to get this in tonight if it's going to make the rc3/1.0 train.

Comment 13

[Darin Fisher]

fixed-on-branch

Comment 14

[Randell Jesup [:jesup] (needinfo me)]

Case-sensitive URL's - I was thinking the hostname was still included here, but
it's not, this is the path following the hostname.  http: (etc) hostnames are
case-insensitive as per the W3C spec.  My apologies; just trying to be
ultra-paranoid about late fixes.

Comment 15

[Dan Mellem]

Wow! A patch in a half hour and checked in within 2 1/2. Thanks.

Comment 16

[Darin Fisher]

Dan: thank you very much for pointing out this bug... i'd hate to have seen
mozilla 1.0 go out with this bug!!  we really need better regression testing for
things like this.

Comment 17

[Tom Everingham]

checked this with packet trace of authenticated proxy transaction.  (Used
tegu.mozilla.org.)   Proxy-authorization: header is now sent with each
connection to the proxy server.

verified branch winNT 20020522

Comment 18

[benc]

*** Bug 132874 has been marked as a duplicate of this bug. ***

Comment 19

[Tom Everingham]

verified - winNT4 11/21/02 trunk - confirmed with packet trace that
proxy-authentication header sent with each connection