146194 - sidebar search's next button does not reset count with a new search

Status: RESOLVED FIXED

(SeaMonkey :: Search, defect)

Description

[Seth]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0rc2) Gecko/20020510
BuildID:    2002051009

Searching a website (like google) with the search sidebar, yields results.  The
sidebar has a next button that shows the next results.  Say you push it until
the results shown are numbers 61-80.  Now you do another search from the
sidebar, and it shows results 1-20.  If you push next it SHOULD show you numbers
21-40, however it shows you numbers 81-100.  The count should be reset with each
new search.

Reproducible: Always
Steps to Reproduce:
1.Search using google in the search sidebar for "boogers"
2.Press next
3.Search using google in the search sidebar for "boogers are nice to eat"
4.Press next

Actual Results:  The page shown is google results from 41-50

Expected Results:  It should have shown pages 21-50, according to the google.src
Sherlock2 specification

Note that there is a bug in the google.src specification as well in that the
increment for next and previous are both 20, while google only searches 10 at a
time.

Comment 1

[Kai Lahmann (is there, where MNG is)]

can you still reproduce this with a recent mozilla version like 1.1beta?

Comment 2

[Erich 'Ricky' Iseli]

Confirming. And the bug you are mentioning at the end of your report is bug
149631. Marking it dependent of it.

Comment 3

[Erich 'Ricky' Iseli]

Sorry, forgot to mention that I'm confirming with the latest nightly, build ID
2002111321

Comment 4

[Robert Strong (they/them - no direct email)]

Attachment: patch rev 1

The attached patch solves this bug by setting the global var gPageNumber to 0
when a search is performed. This also fixes the problem where gPageNumber is
off by one when changing the direction of the search results by using the Next
/ Previous buttons.

Comment 5

[Robert Strong (they/them - no direct email)]

Comment on attachment 174467 [details] [diff] [review]
patch rev 1

Not sure who to ask to r and sr and chose caillon for r after looking at Bug
149631.

Comment 6

[Robert Strong (they/them - no direct email)]

Attachment: patch

After reading several other search bugs it is apparent that the fix for the
previous next issue should be done elsewhere so this patch now only contains
the fix for this bug.

Comment 7

[Robert Strong (they/them - no direct email)]

Comment on attachment 174493 [details] [diff] [review]
patch

I'm guessing who should review the patch and a checkin would be appreciated.
Thanks

Comment 8

[Alec Flett]

Comment on attachment 174493 [details] [diff] [review]
patch

sr=alecf

Comment 9

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in xpfe/components/search/resources/search-panel.js;
/cvsroot/mozilla/xpfe/components/search/resources/search-panel.js,v  <-- 
search-panel.js
new revision: 1.86; previous revision: 1.85
done

Comment 10

[Robert Strong (they/them - no direct email)]

checked using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2)
Gecko/20050220 from the tinderbox and the bug is fixed.