147463 - [FIXr]Content changes size when checkbox is selected

Status: RESOLVED FIXED

(Core :: Layout, defect, P3)

Description

[Mats Palmgren (inactive)]

DESCRIPTION:
Content changes size when checkbox is selected.

REPEAT BY:
1. load http://www.bostream.se/page.php?xml=swe/pages/company/orderservices.xml
2. left-click on the checkbox (to the left of "Ja tack...")

ACTUAL BEHAVIOUR:
Middle part of the content (grey area) shrinks in height, vertical scrollbar
appears. Reload and the page is restored. 100% repeatable.

EXPECTED BEHAVIOUR:
Checkbox selected. No other layout changes.

PLATFORM & BUILD:
Mozilla nightly trunk build, 2002-05-25-04, on Windows 98 SE.
Bug also occurs in Mozilla 1.0 RC3, but slightly different - here the content
grows instead when the checkbox is clicked.

ADDITIONAL INFORMATION:
The URL works fine in IE6 and Opera6.01 on Windows 98 SE.

(See also bug 147457 for another problem on same URL)

Comment 1

[Mats Palmgren (inactive)]

Attachment: Testcase #1

Comment 2

[Mats Palmgren (inactive)]

Testcase #1: clicking the checkbox shrinks the DIV in trunk 2002-05-25-04 and
grows the DIV in Moz 1.0 RC3.

Comment 3

[Mats Palmgren (inactive)]

Attachment: Testcase #2

Testcase #2: even smaller, but only shows shrink problem with trunk build - no
problem in RC3.

Comment 4

[Chris Petersen]

Changing priority to P3.

Comment 5

[Kevin McCluskey (gone)]

-> Rods

Comment 6

[rods (gone)]

-->

Comment 7

[John Keiser (jkeiser)]

Attachment: Minimized Testcase

OK, so anything that causes a reflow (in this case changing style on a button)
reveals a problem with block elements inside div overflow=auto.  Click the
button in this case and you see the same results.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Button reflow has been whacked since.  All the testcases in this bug work for me
now; the original site seems to have changed.

Comment 9

[Mats Palmgren (inactive)]

Attachment: Button size when enabled/disabled

Comment 10

[Mats Palmgren (inactive)]

Attachment: Horizontal scrollbar that should not be there (Testcase #1)

Comment 11

[Mats Palmgren (inactive)]

Attachment: Horizontal scrollbar that should not be there (URL)

Comment 12

[Mats Palmgren (inactive)]

REOPEN: There are still a few problems with Testcase #1 and the URL.

1. The enabled button is 2 pixels wider than what it is disabled.
   See Testcase #1. I have attached a screenshot (400%) of this in
   attachment 121845 [details].

2. When resizing the window horizontally slowly (Testcase #1) the
   horizontal scrollbar does not disappear when it should. Resizing faster
   makes it disappear correctly. See screenshot of this in attachment 121846 [details].

3. Visiting the URL, a horizontal scrollbar appears occasionally.
   See screenshot in attachment 121847 [details]. (Could be the same bug as in 2?)

All three problems are repeatable on both Windows 98 and Linux:
2003-04-26-05 trunk Linux
2003-04-26-08 trunk Windows 98 SE

Comment 13

[Boris Zbarsky [:bzbarsky]]

Attachment: patch for the button changing size

Ah, ok.  So that's what the original bug was about...

This fixes the off-by-one error in sizing disabled buttons.  The scrollbar
thing should probably be a separate bug under block layout.

Comment 14

[Boris Zbarsky [:bzbarsky]]

Taking.

Comment 15

[Mats Palmgren (inactive)]

(spawned off bug 203588 for the scrollbar problem)

Comment 16

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 121851 [details] [diff] [review]
patch for the button changing size

Could this please be approved for 1.4b?  This just fixes a 1px mis-sizing of
disabled buttons...

Comment 17

[Boris Zbarsky [:bzbarsky]]

.

Comment 18

[Asa Dotzler [:asa]]

Comment on attachment 121851 [details] [diff] [review]
patch for the button changing size

a=asa (on behalf of drivers) for checkin to 1.4b

Comment 19

[Boris Zbarsky [:bzbarsky]]

fixed.