147916 - tinderbox sidebar panels shouldn't be on by default for 1.0

Status: RESOLVED FIXED

(SeaMonkey :: Sidebar, defect)

Description

[Daniel (Leaf) Nunes]

sspitzer is already working on a patch.

Comment 1

[(not reading, please use [e-mail] instead)]

Attachment: fix

Comment 2

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 85463 [details] [diff] [review]
fix

r=caillon.

Comment 3

[(not reading, please use [e-mail] instead)]

note, this bug makes #43751 more interesting.

with them gone from defaults, and not being able to add them, new profiles will
have a hard time getting these panels.

Comment 4

[David :Bienvenu]

Comment on attachment 85463 [details] [diff] [review]
fix

sr=bienvenu

Comment 5

[(not reading, please use [e-mail] instead)]

this is fixed on the branch only.

I'll send mail to samir and let him decide if we want this on the trunk as well.

Comment 6

[Dawn Endico]

i don't particularly want it for the trunk. i only asked for it so the
tinderbox server does't get hammered by thousands of curious mozilla 1.0
users who don't actually care about the state of the tree.

otoh, i guess the percentage of actual hackers who use the normal
milestones and daily builds is also pretty low. i think we get 
2k-6k downloads of daily builds. we sure don't have that many hackers.

Comment 7

[(not reading, please use [e-mail] instead)]

for the trunk, we'll also want to remove these three lines from:

http://lxr.mozilla.org/mozilla/source/xpfe/components/sidebar/resources/locale/en-US/local-panels.dtd#28

 26 <!-- LOCALIZATION NOTE sidebar.tinderbox.label: DONT_TRANSLATE -->
 27 <!ENTITY sidebar.tinderbox-seamonkey.label  "Tinderbox: SeaMonkey">
 28 <!ENTITY sidebar.tinderbox-ports.label      "Tinderbox: SeaMonkey-Ports">
 
I think that the tinderbox panels should not be part of mozilla.  they should be
like the other, externally installed panels, see http://dmoz.org/Netscape/Sidebar/

We could list the tbox panel there, so that if the user does "Sidebar
Directory..." they could find it that way.

doing that would fix #43751 as well.

re-assign to samir.  I'll send him a private email about this bug as well.

Comment 8

[(not reading, please use [e-mail] instead)]

Attachment: patch for the trunk, remove tinderbox panels. they should be made external.

Comment 9

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 85466 [details] [diff] [review]
patch for the trunk, remove tinderbox panels.  they should be made external.

If we want to do this for good, then yeah this will do the trick.  r=caillon,
but yeah also get samir's ok and personally, I hope we get these listed on dmoz
or somewhere else _before_ this lands on the trunk...

Comment 10

[Samir Gehani]

Trunk, thus -> mozilla1.1alpha.

Comment 11

[Asa Dotzler [:asa]]

Comment on attachment 85466 [details] [diff] [review]
patch for the trunk, remove tinderbox panels.  they should be made external.

a=asa (on behalf of drivers) for checkin to 1.5beta

Comment 12

[Asa Dotzler [:asa]]

->me

Comment 13

[Asa Dotzler [:asa]]

fix checked in.

Comment 14

[Asa Dotzler [:asa]]

resolving.