148597 - [FIX] Can't drag & drop a bookmark from personal toolbar to tab

Status: RESOLVED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Koike Kazuhiko]

Can't drag & drop a bookmark from personal toolbar to tab.

From bookmark panel in sidebar, drag & drop works.

Comment 1

[Pierre Chanial]

taking, I am the culprit. This is a flavour problem.
Btw, dropping a bookmark from the personal toolbar inside the content view also
fails. I was aware of the latter but not the former. Thanks, Kazuhiko!

Comment 2

[Pierre Chanial]

Attachment: Patch v1.0

There was a bug in navigatorDD.js preexisting to the patch in bug 139471 that
was masked by the ordering of the flavours added to xferData.
The second line is unrelated to this bug and is for correctness. It just
ensures using url instead of uri for text/html

Comment 3

[Pierre Chanial]

r and sr needed.

Comment 4

[Pierre Chanial]

r=timeless on IRC

Comment 5

[Mike Kaply [:mkaply]]

This is also breaking Drag and drop on OS/2 from the Personal Toolbar to the 
desktop.

Comment 6

[djk]

Could this bug also be the reason that dragging a personal toolbar bookmark to
the url bar causes the bookmark _name_ to be pasted rather than the url?

Comment 7

[Pierre Chanial]

djk: you're right, it's the same issue.
this patch fixes also the problem you are reporting.

Comment 8

[Blake Ross]

Comment on attachment 85981 [details] [diff] [review]
Patch v1.0

sr=blake. pch rocks, netscape should hire him.

Comment 9

[Pierre Chanial]

*** Bug 149238 has been marked as a duplicate of this bug. ***

Comment 10

[Asa Dotzler [:asa]]

Comment on attachment 85981 [details] [diff] [review]
Patch v1.0

a=asa (on behalf of drivers) for checkin to the 1.1 trunk.

Comment 11

[[e-mail] (gone - use [e-mail] instead)]

C:\moz_src\mozilla\xpfe\browser\resources\content>cvs commit -m "Bug 148597.
Can't drag a bookmark from personal toolbar to a tab.  Patch by Pierre Chanial
<[e-mail]> r=timeless, sr=blake, a=a
sa" navigatorDD.js
Checking in navigatorDD.js;
/cvsroot/mozilla/xpfe/browser/resources/content/navigatorDD.js,v  <-- 
navigatorDD.js
new revision: 1.89; previous revision: 1.88
done

Fixed on trunk.