148712 - Add component with empty/invalid initial owner results in double header output

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[Stu Tomlinson]

Adding a new component, and filling in the component name and description with
either an empty or invalid initial owner results in the header HTML (including
the initial "Content-type:text/html") being shown twice. (eg. the "error
handling" thinks it's got the whole page to display).

The call to DBNameToIdAndCheck (line 401) in editcomponents.cgi seems to be
extraneous - the check for an empty owner never gets called, and the safer check
for invalid account that doesn't mess up the output doesn't get called.

Deleting that line seems a safe and sensible thing to do.

Comment 1

[Stu Tomlinson]

Attachment: (v2.16rc1) Remove extraneous check

Comment 2

[Jouni Heikniemi]

Comment on attachment 86006 [details] [diff] [review]
(v2.16rc1) Remove extraneous check

>     my $initialowner = trim($::FORM{initialowner} || '');
>-        #
>-        # Now validating to make sure it's too an existing account
>-        #
>-        DBNameToIdAndCheck($initialowner);

This is right, but the error msg is less prominent after the fix. Well, 
this will be rewritten soon anyway, so I don't particularly care 
about the ugliness (not like it were anything beautiful now, though).

The reason behind this odd double logic is a cascade of several events. 
If someone wants to investigate further, see CVS revisions 1.14, 1.16
and 1.19 on the cgi. Relevant are also bug 24806 and bug 66876.

r=jouni

Comment 3

[Dave Miller [:justdave]]

-> patch author

Comment 4

[Bradley Baetz (:bbaetz)]

Comment on attachment 86006 [details] [diff] [review]
(v2.16rc1) Remove extraneous check

r=bbaetz

Comment 5

[Bradley Baetz (:bbaetz)]

Checked in, trunk + branch.