149730 - DNS Service must shutdown

Status: VERIFIED FIXED

(Core :: Networking, defect)

Description

[Doug Turner (:dougt)]

not shutting down causes all sorts of pain

Comment 1

[Doug Turner (:dougt)]

Attachment: Shuts down DNS at XPCOM Shutdown

Comment 2

[Darin Fisher]

Comment on attachment 86697 [details] [diff] [review]
Shuts down DNS at XPCOM Shutdown

looks good to me.

Comment 3

[Darin Fisher]

Comment on attachment 86697 [details] [diff] [review]
Shuts down DNS at XPCOM Shutdown

looks good to me.  sr=darin

Comment 4

[rpotts (gone)]

Comment on attachment 86697 [details] [diff] [review]
Shuts down DNS at XPCOM Shutdown

r=[e-mail]

Comment 5

[Doug Turner (:dougt)]

landed the fix on the trunk last night.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 86697 [details] [diff] [review]
Shuts down DNS at XPCOM Shutdown

Please land this on the 1.0.1 branch.  Once there, replace the
"mozilla1.0.1+" keyword with the "fixed1.0.1" keyword.

Comment 7

[benc]

+qawanted: Is there some way to test this behavior?

Comment 8

[benc]

Dougt: Is there a way to test this externally or internally? I can probably get
some whitebox QA to look at this if that is needed.

Comment 9

[Doug Turner (:dougt)]

code level fix. have david look at this.

Comment 10

[benc]

david: can you look at this?

Comment 11

[David Epstein]

verified patch against Mozilla 1.2b Mozilla/5.0 (Windows; U; WinNT4.0; en-US;
rv:1.2b) Gecko/20021105 build. XPCOM shutdown observer added in
nsDnsService.cpp. No console msg for DNSService shutdown.