Closed
Bug 149745
Opened 23 years ago
Closed 23 years ago
no mInfo causes odd crash
Categories
(Core :: XPConnect, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: dougt, Assigned: dougt)
Details
Attachments
(1 file)
|
1.95 KB,
patch
|
dbradley
:
review+
rpotts
:
superreview+
|
Details | Diff | Splinter Review |
In xptcall/src/md/win32/xptcstubs.cpp, we do not check errors return from:
iface_info->GetMethodInfo(PRUint16(methodIndex), &info);
However, we do not initalize |info|. This patch fixes that so when this method
fails, you at least see the assertion. Without this patch, you will crash in
different places.
This patch also clears the global:
static xptiInterfaceInfoManager* gInterfaceInfoManager = nsnull;
during shutdown.
|
Assignee | |
Comment 1•23 years ago
|
||
|
||
Comment 2•23 years ago
|
||
Attachment #86703 -
Flags: superreview+
|
||
Comment 3•23 years ago
|
||
Comment on attachment 86703 [details] [diff] [review]
Fixes problem
r=dbradley
Is this still an exceptional error or should we check for the failure and
return it from PrepareAndDispatch?
Attachment #86703 -
Flags: review+
|
|
Assignee | |
Comment 4•23 years ago
|
||
mInfo is only set during a really bad shutdown - restart. The assertion is good
enough to indicate this state. Eg. We shouldn't enable restaring if this
problem persists.
I will try to get it checked in. over to me.
Assignee: dbradley → dougt
|
|
Assignee | |
Comment 5•23 years ago
|
||
landed the fix on the trunk last night.
|
|
Assignee | |
Updated•23 years ago
|
Keywords: fixed1.0.1
You need to log in
before you can comment on or make changes to this bug.
Description
•