149874 - [xlib] Spacebar doesn't toggle checkbox or radio buttons

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[David Olivari]

Go to :
resource:///res/samples/test8.html

Try to toggle radio buttons, checkbox or buttons only using TAB and SPACE key.

Comment 1

[David Olivari]

I forgot to precise to use a xlib port of Mozilla

Comment 2

[David Olivari]

at
http://lxr.mozilla.org/mozilla1.0/source/widget/src/xlib/nsKeyCode.cpp#73
the XK code used is XK_KP_Space
on my xserver with xev command, I receive XK_space.
the patch attached add a line in nsKeyCode.cpp :
{ NS_VK_SPACE, XK_space},

Comment 3

[David Olivari]

Attachment: Keycode patch

Comment 4

[Boris Zbarsky [:bzbarsky]]

To blizzard; please take a look at the patch?

Comment 5

[rods (gone)]

-->

Comment 6

[John Keiser (jkeiser)]

-> xlib dude.

Comment 7

[timeless]

Comment on attachment 86798 [details] [diff] [review]
Keycode patch

This fixes the problem.
drivers: i'm slowly adding xlib and qt maintenance back into my list of
projects, for the most part ii'm only going to be working on showstoppers
(crashers, build failures, major things that don't work), the fixes will all be
simple and localized to directories which are not part of the normally
win/gtk/mac build,

Comment 8

[Asa Dotzler [:asa]]

Comment on attachment 86798 [details] [diff] [review]
Keycode patch

a=asa for checkin to 1.3a

Comment 9

[timeless]

checked in