150158 - javascript strict warnings in sidebarOverlay.js

Status: RESOLVED FIXED

(SeaMonkey :: Sidebar, defect)

Description

[Henrik Gemal]

just starting mozilla produces these:

Warning: reference to undefined property sidebar_file.delete
Source File: chrome://communicator/content/sidebar/sidebarOverlay.js
Line: 851

20020607

Comment 1

[Samir Gehani]

helpwanted

Comment 2

[Steve Chapel]

The comment above line 851 explains that the code is a workaround for bug 37406.
That bug has been fixed, and it renamed the delete method call to remove. It
looks like we need to call remove instead of delete, and we can use normal
method call notation and remove the comment. Also, I think
chrome://inspector/content/search/modules/junkImgs/junkImgs.xml line 127 has the
same problem.

Comment 3

[Steve Chapel]

Attachment: Rename delete method call to remove in all three files

Found another call to delete in
chrome://inspector/content/jsutil/system/file.js line 184. This patch fixes all
three files to call the remove method instead.

Comment 4

[Henrik Gemal]

Warning: redeclaration of var ds
Source File: chrome://communicator/content/sidebar/sidebarOverlay.js
Line: 805, Column: 8
Source Code:
    var ds = RDF.GetDataSource(sidebarObj.datasource_uri);

Comment 5

[Steve Chapel]

I don't understand why my patch is marked obsolete. Line 805 of
sidebarOverlay.js is more than 60 lines from code my patch touches and in a
different function.

Comment 6

[Brendan Eich [:brendan]]

Comment on attachment 102109 [details] [diff] [review]
Rename delete method call to remove in all three files

This kind of change can go in without sr= -- it ought to be fixed for 1.4beta,
no?

/be

Comment 7

[Asa Dotzler [:asa]]

Comment on attachment 102109 [details] [diff] [review]
Rename delete method call to remove in all three files

a=asa (on behalf of drivers) for checkin to 1.4b

Comment 8

[Steve Chapel]

Could someone please check this in for me? I don't have cvs access.

Comment 9

[[e-mail]]

Fix checked in.