150332 - default focus in "Download Headers" dialog should be the OK button

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Henrik Gemal]

When you get the "Download Headers" dialog you cant just press SPACE. The
default fous on the dialog should be on the OK button so that pressing space is
like hitting the OK button.

Comment 1

[Karsten Düsterloh]

Attachment: Focus OK button on dialog startup

Comment 2

[Karsten Düsterloh]

Comment on attachment 180475 [details] [diff] [review]
Focus OK button on dialog startup

one-liner

Comment 3

[Asa Dotzler [:asa]]

Comment on attachment 180475 [details] [diff] [review]
Focus OK button on dialog startup

a=asa

Comment 4

[Robert Kaiser]

Checked in.

Comment 5

[Henrik Gemal]

will this also affect tbird?

Comment 6

[Karsten Düsterloh]

Yes, this dialog is shared.

Comment 7

[Mike Cowperthwaite]

I'm not so sure this was a good change to make.  With the focus on the radio 
button, you could change the option immediately using the arrow keys, if you 
didn't want the selection; as it stands now, changing via the keyboard now 
requires navigating back to the radio buttons.

The "Download" button is the default button, so pressing ENTER accepts the 
dialog regardless of where the focus is.  That is expected and desirable UI.  
Pressing "space" to activate the button may be what you do normally, but that's 
not the assumed behavior behind the design of dialog boxes' focus and default 
button.

Comment 8

[Karsten Düsterloh]

The rational behind this is the usual workflow of "spacing" through your
messages, probably getting a dialog "change group?", confirming that with space,
entering next group, getting asked about how many messages to load, but since
you've set that limit, you won't change it most of the time, thus hitting space
to get on, "spacing" through the next messages...

Actually, I don't think that the focus in this dialog was set anywhere
*intentionally*.