1508836 - CI debug builds are updated to recent Firefox Nightly builds

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

As noticed while investigating bug 1508726 a local CI debug build from autoland on MacOS gets updates offered to an opt Nightly build on mozilla-central.

Steps:
1) Download the build from https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=51abb63ca2464f588229752a5c6070f459a74e6b&selectedJob=212442948

2) Start Firefox and check for updates

As Firefox shows in the about dialog the update channel is set to the nightly channel, and accepted mar channels allows firefox-mozilla-central.

As asked on IRC this is not an allowed update path, and was regressed sometime in the past.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

For reference here the related log entries:

> *** AUS:SVC Checker: checkForUpdates, force: true
> *** AUS:SVC UpdateService.canCheckForUpdates - able to check for updates
> *** AUS:SVC Checker:getUpdateURL - update URL: https://aus5.mozilla.org/update/6/Firefox/65.0a1/20181117212204/Darwin_x86_64-gcc3/en-US/nightly/Darwin%2017.7.0/ISET:SSE4_2,MEM:16384/default/default/update.xml?force=1
> *** AUS:SVC Checker:checkForUpdates - sending request to: https://aus5.mozilla.org/update/6/Firefox/65.0a1/20181117212204/Darwin_x86_64-gcc3/en-US/nightly/Darwin%2017.7.0/ISET:SSE4_2,MEM:16384/default/default/update.xml?force=1

Comment 2

[Tom Prince [:tomprince]]

Attachment: Bug 1508836: Don't try to guess MOZ_UPDATE_CHANNEL in automation;

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1508836 - Use the "default" update channel on debug builds.

Comment 4

[Mike Hommey [:glandium]]

Fixed by a backout of bug 1502457