150906 - viamichelin.com - Select a map region does not work, selection line does (not) stick.

Status: VERIFIED WORKSFORME

(Tech Evangelism Graveyard :: French, defect)

Description

[Eric L.]

when going to the URL http://www.viamichelin.com and searching for a map
(e.g. City=Grenoble, Address=alsace-lorraine), you get a map where you can
theoretically (works with IE5.5) select a region to zoom in. With Moz1.0 and
preceding, the selection rectangle sticks to the mouse cursor and not to the
map, and it's therefore not possible to zoom in this way.

I got the same problem with Linux and Windows2000, Mozilla since 0.9.? until
1.0 final.

I recognize that might be an evangelism problem but as I don't speak JavaScript...

Comment 1

[Phil Schwartau]

Confirming report with Mozilla trunk binary 20020617xx on WinNT.

In http://www.viamichelin.com/viamichelin/gbr/js/map/drag2.js
there are functions like this:

function mouseMove(e)
{
 var mouseX = (ns||moz ? e.pageX : event.clientX + document.body.scrollLeft);
 var mouseY = (ns||moz ? e.pageY : event.clientY + document.body.scrollTop);

 if (isClick)
 {
  showSelection(mouseX, mouseY);
  return false;
 }

 return true;
}


See that flag |isClick|? It gets set to |true|, and never seems
to get set to |false| in Mozilla. The only place that can happen
is in a function called MouseUp(). However, setting a breakpoint
in the Mozilla JS Debugger shows that function never gets called!


Note: here's  where the event handlers are bound to the events:

if (moz)
{
  var theDiv = document.getElementById("region");
  SelectionDiv = document.getElementById("selection");
  CrossDiv = document.getElementById("centerpoint");
  minX = parseInt(theDiv.style.left);
  maxX = minX + parseInt(theDiv.style.width);
  minY = parseInt(theDiv.style.top);
  maxY = minY + parseInt(theDiv.style.height);
  CrossDiv.style.left = minX + (maxX - minX) / 2 - 10;
  CrossDiv.style.top = minY + (maxY - minY) / 2 - 10;
  theDiv.addEventListener("mousedown",mouseDown,false);
  theDiv.addEventListener("mousemove",mouseMove,true);
  theDiv.addEventListener("mouseup",mouseUp,true);

Comment 2

[Phil Schwartau]

Reassigning to DOM Events -

cc'ing jst, bzbarsky, jkeiser - are they using correct syntax
to bind the event handlers?

Comment 3

[Boris Zbarsky [:bzbarsky]]

Yeah, that looks correct to me.... Does changing the last arg (the capture arg)
to "false" change anything?

Comment 4

[Boris Zbarsky [:bzbarsky]]

*** Bug 148763 has been marked as a duplicate of this bug. ***

Comment 5

[Michael Lefevre]

*** Bug 161518 has been marked as a duplicate of this bug. ***

Comment 6

[jfchadeyron]

what's new ?

Comment 7

[Vladimir Ermakov]

This is working on buid 2002-12-20-08-trunk. win 2k and 7.01 build on mac osx

Comment 8

[jfchadeyron]

this bug isn't resolved !!!

Comment 9

[Boris Zbarsky [:bzbarsky]]

Yep, reopening.  Quite broken on Linux trunk build 2003-01-31-22.

Comment 10

[jfchadeyron]

i have this bug with build 2003021005 under windows xp !
:'(

Comment 11

[jfchadeyron]

...

Comment 12

[jfchadeyron]

could'nt include this fonction in the next mozilla release ?
(www.viamichelin.com is a leader site...)

Comment 13

[Boris Zbarsky [:bzbarsky]]

This is impossible to fix without a small testcase pointing out what actually
fails....

Comment 14

[Dean Peterson]

I started making a test case, but I think the bug is in the web page, not Mozilla.

The resizable selection "rubber band" on the page is actually the border of an
absolutely positioned div element (id=ViaM_selection).  Once the mouseDown event
makes that div visible, the mouseMove event keeps resizing it so that it always
extends out to the mouse cursor location.  Therefore, when you release the mouse
button, the cursor is over the corner of the selection div, and it receives the
event instead of the div beneath (id=ViaM_region) that the mouseUp handler is
actually tied to.  (The only reason the mouseMove event reaches the handler on
the div beneath is because the mouse cursor was just moved off the corner of the
selection div.  In fact, if you try to resize the selection area smaller, it
doesn't work.)

They did pass true for the useCapture parameter of addEventListener, but if read
the DOM Level 2 spec right it sounds like event capture only happens on elements
that are ancestors in the document tree structure, not elements that just happen
to contain another element visually.  The selection div is not a descendent node
of the div beneath it visually.  Is my interpretation of the spec correct?

The site does include Mozilla/Netscape 6-7 specific code branches, so
ViaMichelin isn't ignoring Mozilla.  I don't know if it's a simple bug or a
misunderstanding of the DOM Level 2 Events spec, probably just a bug.  Would
this be something for tech evangelism?

Comment 15

[Boris Zbarsky [:bzbarsky]]

See bug 102695

Comment 16

[Dean Peterson]

Unless borders don't count, I don't think this page would work even if
transparent areas were made transparent to events (bug 102695).  The mouse
cursor is usually over the div's visible border. 

Comment 17

[Boris Zbarsky [:bzbarsky]]

Ah.  In that case, evangelism.  Dean, thanks for debugging this!

Comment 18

[Dean Peterson]

You're very welcome.

Comment 19

[Kai Lahmann (is there, where MNG is)]

*** Bug 193028 has been marked as a duplicate of this bug. ***

Comment 20

[Mathieu Pillard [:mat]]

site is french, main language is french, moving to french component :)

Comment 21

[Michel Poleur]

It works for me now.

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.4) Gecko/20030624

Comment 22

[Aurele Venet]

Works for me as well!  Fantastic job, well done and thank you very much!

Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:1.4) Gecko/20030701

Comment 23

[Mathieu Pillard [:mat]]

Wfm with mozilla 1.4 as well. what shall we change the resolution to ? I don't
know if the problem was with the site or with moz :)

Comment 24

[Adam Hauner]

-> WFM (per previous comments)

Comment 25

[Mathieu Pillard [:mat]]

verified.