151072 - HP bustage in xpcom

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Chris McAfee]

This checkin

http://bonsai.mozilla.org/cvsquery.cgi?module=MozillaTinderboxAll&date=explicit&mindate=1023818220&maxdate=1023824459

caused this error:

Error 129: "../../../dist/include/xpcom/nsTraceRefcnt.h", line 73 # Redefinition
of macro 'NS_LOG_ADDREF' differs from previous definition at
["../../../dist/include/xpcom/nsISupportsImpl.h", line 52].
    #define NS_LOG_ADDREF(_p, _rc, _type, _size) \
            ^^^^^^^^^^^^^                         
Error 129: "../../../dist/include/xpcom/nsTraceRefcnt.h", line 76 # Redefinition
of macro 'NS_LOG_RELEASE' differs from previous definition at
["../../../dist/include/xpcom/nsISupportsImpl.h", line 53].
    #define NS_LOG_RELEASE(_p, _rc, _type) \
            ^^^^^^^^^^^^^^                  
Error 129: "../../../dist/include/xpcom/nsTraceRefcnt.h", line 105 #
Redefinition of macro 'MOZ_COUNT_CTOR' differs from previous definition at
["../../../dist/include/xpcom/nsISupportsImpl.h", line 59].
    #define MOZ_COUNT_CTOR(_type)                                 \
            ^^^^^^^^^^^^^^                                         
Error 129: "../../../dist/include/xpcom/nsTraceRefcnt.h", line 110 #
Redefinition of macro 'MOZ_COUNT_DTOR' differs from previous definition at
["../../../dist/include/xpcom/nsISupportsImpl.h", line 60].
    #define MOZ_COUNT_DTOR(_type)                                 \
            ^^^^^^^^^^^^^^                                         
gmake[5]: *** [nsDebug.o] Error 2
gmake[5]: Leaving directory
`/builds/tinderbox/SeaMonkey/HP-UX_B.11.00_Clobber/mozilla/xpcom/glue/standalone'
gmake[4]: *** [libs] Error 2
gmake[4]: Leaving directory
`/builds/tinderbox/SeaMonkey/HP-UX_B.11.00_Clobber/mozilla/xpcom/glue'
gmake[3]: *** [libs] Error 2
gmake[3]: Leaving directory
`/builds/tinderbox/SeaMonkey/HP-UX_B.11.00_Clobber/mozilla/xpcom'
gmake[2]: *** [tier_2] Error 2
gmake[2]: Leaving directory
`/builds/tinderbox/SeaMonkey/HP-UX_B.11.00_Clobber/mozilla'
gmake[1]: *** [default] Error 2
gmake[1]: Leaving directory
`/builds/tinderbox/SeaMonkey/HP-UX_B.11.00_Clobber/mozilla'
gmake: *** [build] Error 2

Comment 1

[Doug Turner (:dougt)]

jdunn, your suggestion didn't complete work.  Can I get some time on your box?

Comment 2

[Jim Dunn]

I think this is a compiler versioning issue.
palermo is at aCC 3.25
however it looks like aCC 3.34 handles this ok.
we have to upgrade anyway... so am re-assigning
this to Martin and he will upgrade the compiler
later today.  I will also "turn off" this tbox
till we get it fixed.

Comment 3

[Martin Lawyer]

All recommended patches and updates have been applied to palermo, included the
3.34 compiler update.

Comment 4

[Martin Lawyer]

After the update, it's still broken. 

Might be the --enable-logrefcnt flag.    Removed that flag, and restarted tbox. 

This flag *should* be ok to use.  Might still need to revisit the original code
change that started this. 

Comment 5

[Philip K. Warren]

We are seeing a similar error on AIX when building with the --enable-logrefcnt flag.

Comment 6

[Philip K. Warren]

I think the correct fix would be to back out this change:

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=mozilla/xpcom/glue&command=DIFF_FRAMESET&file=nsISupportsImpl.h&rev1=3.8&rev2=3.9&root=/cvsroot

and add the following to nsTraceRefcnt.h:

#if defined(XPCOM_GLUE)
#undef NS_BUILD_REFCNT_LOGGING
#endif

Comment 7

[Philip K. Warren]

Attachment: Suggested fix

Without this fix, we are unable to build with --enable-debug on AIX.

Comment 8

[Doug Turner (:dougt)]

Comment on attachment 93318 [details] [diff] [review]
Suggested fix

looks fine.

Martin, if you don't have time to walk this into the tree, reassign it to me.

Comment 9

[Martin Lawyer]

Reassigning.  Thanks Doug. 

Comment 10

[Alec Flett]

Comment on attachment 93318 [details] [diff] [review]
Suggested fix

sr=alecf

Comment 11

[Doug Turner (:dougt)]

Checking in base/nsTraceRefcnt.h;
/cvsroot/mozilla/xpcom/base/nsTraceRefcnt.h,v  <--  nsTraceRefcnt.h
new revision: 1.27; previous revision: 1.26
done
Checking in glue/nsISupportsImpl.h;
/cvsroot/mozilla/xpcom/glue/nsISupportsImpl.h,v  <--  nsISupportsImpl.h
new revision: 3.10; previous revision: 3.9
done

Checked into trunk.

Thanks for the fix.