1513372 - Tabstrip/Titlebar color incorrect in Light/Dark themes

Status: RESOLVED DUPLICATE of bug 1504766

(Firefox :: Theme, defect)

Description

[Tomislav Jovanovic :zombie]

[Tracking Requested - why for this release]:

The Tabstrip/Titlebar is using the system color on Windows 10 as of 65 beta (on Nightly 66 as well, didn't notice because Default theme seems fine).

Comment 1

[:Gijs (he/him)]

Can you find a regression window?

Comment 2

[Itiel]

I believe this was intentional by bug 1503022.

Comment 4

[Tomislav Jovanovic :zombie]

Attachment: dark.png

I can't find a single Windows 10 app that both:

1) honors dark mode (like Firefox), and
2) uses accent color for title bar (in dark mode).

All the examples in bug 1503022 show apps that don't respect the dark mode setting in Windows.  My screenshot attached shows all apps I could find that do honor it, and none of them use the accent color for the title bar except Firefox (not shown: the settings use it for the minimize/maximize/close buttons when focused).

And though VS Code doesn't respect the global dark setting, they recently switched to custom-drawn title bar, specifically to be able to make it dark for dark themes, and called it out in release notes:

https://code.visualstudio.com/updates/v1_27#_custom-title-bar-and-menus-on-windows-and-linux


Hey Dao, sorry for undoing your decision and reopening, but I believe this was probably a mistake, could we please reconsider the decision?

Comment 5

[Tomislav Jovanovic :zombie]

Also, it seems original bug was a complain by a single person who "only selected dark mode in windows because this settings app gives me eye cancer in light mode", and for which a workaround existed.

With the current setup, there is no workaround, and we've had more complains/duplicate bugs than before.

Comment 6

[Tomislav Jovanovic :zombie]

Attachment: dark-settings.png

(In reply to Tomislav Jovanovic :zombie from comment #4)
> All the examples in bug 1503022 show apps that don't respect the dark mode setting in Windows.

I misspoke, one of the examples was the Settings app, but that was either an older build of Windows, or some other non-standard setting.  


> (not shown: the settings use it for the minimize/maximize/close buttons when focused).

This seemed more like a bug than intentional behavior, and sure enough, just checked on another computer with the latest update 1809, and Settings Titlebar is dark even when focused, as shown in attachment.

Comment 7

[Dão Gottwald [:dao]]

(In reply to Tomislav Jovanovic :zombie from comment #5)
> With the current setup, there is no workaround, and we've had more
> complains/duplicate bugs than before.

Yes, there is:

Settings -> Colors -> Show the accent color on the following surfaces -> Uncheck "Title bars". I believe it's unchecked by default and you explicitly enabled it. Just undo that.

You may disagree that bug 1504766 is invalid, but this still seems like a duplicate.