152133 - Deleting an address book entry leaves a blank entry in any mailing lists on which it was a member

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Description

[Christian Dümmer]

To replicate:
1. Create new address book entry ("test")
2. Create new list
3. Add test entry to list
4. Verify both the address book and the list, the test entry should be on both
of them.
5. Go to address book (NOT the list) and delete the test entry.
6. Verify the mailing list. The entry "test" has been replaced by a blank entry.

Comment 1

[laurel]

ran into this today on the aug14 branch build, the blank entry in the mailing
list doesn't appear to go away even after restart.

Comment 2

[(not reading, please use [e-mail] instead)]

mass re-assign.

Comment 3

[OstGote!]

Problem is still there with Mozilla 1.6b on WinNT4. I've just stumbled across
this  . First I looked only for "empty entry". Could you please extend the summary?

Yes, even after restart the blank entry is shown. You can delete the entry as
usual. Note: No immediately GUI refresh due to bug 181165.

Comment 4

[Jeff MAURY]

Reproduced in 1.7RC1

Comment 5

[Gérard Talbot]

*** Bug 256131 has been marked as a duplicate of this bug. ***

Comment 6

[OstGote!]

*** Bug 270413 has been marked as a duplicate of this bug. ***

Comment 7

[Mark Banner (:standard8)]

Attachment: Patch to fix

This patch fixes the problem of the "blank entry".

Rational: When a card is deleted from the address book, the details are passed
round the system and RemoveCardFromMailList is called, however that only
removes the entry from the local "copy" of the address lists (m_AddressList)
and not the database itself. Hence we get the blank entry.

Calling DeleteCardFromMailList on the database, removes the appropriate entry,
however we don't need to notify everyone, as we've just been doing that with
the delete of the card from the address book. Additionally, even if we do
notify everyone it doesn't fix the m_AddressList problem for us, so we need to
keep that in there.


I've tested deleting entries that are contained in multiple lists and single
lists, and I've also checked that if you have the same entry in two address
books and mailing lists (yes I know they *should* be different...) that that
works correctly as well. Deletion of multiple cards from address books at the
same time also works ok.

Comment 8

[Mark Banner (:standard8)]

Housekeeping - this affects all platforms. Guessing at target milestone.

Comment 9

[Mark Banner (:standard8)]

Comment on attachment 172488 [details] [diff] [review]
Patch to fix

Cancelling review for two reasons: 1) Investigating bug 280463 which is related
to this area of code and is a crasher and 2) there should be a null pointer
check.

Comment 10

[Mark Banner (:standard8)]

The patch for this bug has now been incorporated into 280463. Adding dependency
and will recheck once that one is fixed.

Comment 11

[Mark Banner (:standard8)]

Ok, this fix has been checked in alongside that for bug 280463 by timeless,
marking as fixed.

Fix checked in by timeless:
2005-03-02 10:24	timeless%mozdev.org 	mozilla/ mailnews/ addrbook/ src/
nsAbMDBDirectory.cpp 	1.43 	25/2 

Comment 12

[Mark Banner (:standard8)]

*** Bug 272999 has been marked as a duplicate of this bug. ***

Comment 13

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using build 2005-07-15-05 on Windows XP SeaMonkey trunk.