152834 - When Viewing Images, "Stopped" appears on status bar

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect, P1)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

From bug 92947 comment 12:
This seems to have caused "Stopped" to show when you're viewing an image (e.g.
right-click on the mozilla banner and select "View Image").

this can only happen when onStateChange reveives an NS_ERROR_BINDING_ABORTED.

Comment 1

[Darin Fisher]

i'm going to guess that this is an imagelib bug... i know that it sometimes
cancels HTTP loads when it discovers that it can just use its own cached copy.
so i suspect this imagelib is somehow letting NS_BINDING_ABORTED "leak out."

Comment 2

[Craig]

This happens under Windows too. OS shouldn't be just Linux.

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

presumable this line is causing this bug:
http://lxr.mozilla.org/seamonkey/source/modules/libpr0n/src/imgLoader.cpp#572

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: fix

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

taking

Comment 6

[Darin Fisher]

Comment on attachment 121029 [details] [diff] [review]
fix

sr=darin

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 121029 [details] [diff] [review]
fix

This small makes it so that loading "standalone" images don't show "Stopped" in
the statusbar if the image was loaded from the cache... would be nice to have
in 1.4b.

Comment 8

[(not reading, please use [e-mail] instead)]

Comment on attachment 121029 [details] [diff] [review]
fix

lxr for NS_BINDING_ABORTED, my gut tells me to check if anyone expecting it.

Comment 9

[Christian :Biesinger (don't email me, ping me on IRC)]

sspitzer: lxr'ing for that code shows that very few places check for that error
code.

Note that my change only affects code which uses nsImageDocument, as that's the
only caller of LoadImageWithChannel.

And I can't find a user of that checking explicitly for NS_BINDING_ABORTED,
except nsBrowserStatusHandler.js which is the reason why I'm changing the error
code.

Comment 10

[Asa Dotzler [:asa]]

Comment on attachment 121029 [details] [diff] [review]
fix

a=asa (on behalf of drivers) for checkin to 1.4b.

Comment 11

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in public/ImageErrors.h;
/cvsroot/mozilla/modules/libpr0n/public/ImageErrors.h,v  <--  ImageErrors.h
new revision: 1.2; previous revision: 1.1
done
Checking in src/imgLoader.cpp;
/cvsroot/mozilla/modules/libpr0n/src/imgLoader.cpp,v  <--  imgLoader.cpp
new revision: 1.70; previous revision: 1.69
done