152935 - Pref for no notification on Target Milestone change not respected.

Status: RESOLVED FIXED

(Bugzilla :: Email Notifications, defect)

Description

[Jody McIntyre]

I am running Bugzilla 2.14.2 and some of my users have turned off email
notification for "Priority, status, severity, and milestone changes".  However,
notifications are still being sent when the milestone changes.

I posted this problem to n.p.m.webtools and Gerv replied with information on
where to put debugging warnings.  Based on this, I was able to fix the problem.
 It seems that while userprefs.cgi says "Status" controls "Priority, status,
severity, and milestone changes", getEmailAttributes($@) in processmail only
returns "Status" if Severity, Status, or Priority changes.

I will attach a very small patch for your consideration.

Comment 1

[Jody McIntyre]

Attachment: Patch to add "Target Milestone" check to getEmailAttributes($@)

Comment 2

[Bradley Baetz (:bbaetz)]

The patch looks reversed, but apart from that it looks OK. Is this still a
porblem in HEAD?

Comment 3

[Jouni Heikniemi]

Comment on attachment 88354 [details] [diff] [review]
Patch to add "Target Milestone" check to getEmailAttributes($@)

Yes, this is correct (apart from being reverse) and also a head bug. The patch
even applies to the trunk tip, although with some fuzz and offset. 

Thanks for the patch, Jody!

2xr=jouni

Comment 4

[Jouni Heikniemi]

-> patch author

Comment 5

[Gervase Markham [:gerv]]

Fixed.

Checking in processmail;
/cvsroot/mozilla/webtools/bugzilla/processmail,v  <--  processmail
new revision: 1.88; previous revision: 1.87
done

Gerv