153892 - mcdonalds.se - script errors when working with Flash plug-in

Status: RESOLVED FIXED

(Tech Evangelism Graveyard :: Other, defect)

Description

[Johan Alderud]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.0.0) Gecko/20020530
BuildID:    2002053012

The javascript engine behaves differently depending on wether the Flash plug-in
is installed or not. The javascript can be found at
http://www.mcdonalds.se/Sweden/Index.nsf/flashredirector.html

Reproducible: Always

Steps to Reproduce:
1. Open Mozilla 1.0 (without Flash installed)
2. Open http://www.mcdonalds.se
3. Observe that the topFrame does not display any content.
4. Enter javascript: in the adressbar.
5. Observe the errormessage related to "detectFlashActiveX".
6. Install Flash plug-in.
7. Repeat step 1-2.
8. Observe that the topFrame does display content (menusystem).

Actual Results:  Javascript errors are produced and the script is terminated.

Expected Results:  Javascript errors should not have been produced and the
script should complete.

Comment 1

[Ian Neal]

Using BuildID 2002061712 after removing the flash plugin I get the following
error messages in the JS console:

Error: detectFlashActiveX is not defined
Source File:
http://www.mcdonalds.se/Sweden/SiteDocuments.nsf/FlashRedirector.html!ReadForm
Line: 29

Error: detectFlashActiveX is not defined
Source File: http://www.mcdonalds.se/Sweden/Index.nsf/detectflash.js
Line: 10

Possibly should be marked as Tech Evangelism

Comment 2

[Phil Schwartau]

Here is http://www.mcdonalds.se/Sweden/Index.nsf/detectflash.js

with(document) {
  writeln('<script language="VBScript">');
  writeln('function detectFlashActiveX()');
  writeln('on error resume next');
  writeln('detectFlashActiveX=(IsObject(CreateObject(
                                        "ShockwaveFlash.ShockwaveFlash.5")))');
  writeln('end function');
  writeln('</script>');
}

var gotFlash=false;

if( ( navigator.mimeTypes &&
navigator.mimeTypes['application/x-shockwave-flash'] && parseInt(
navigator.mimeTypes['application/x-shockwave-flash'].enabledPlugin.description.substring(
navigator.mimeTypes['application/x-shockwave-flash'].enabledPlugin.description.indexOf(
'.' ) - 1 ) ) >= 5 ) || ( navigator.userAgent.indexOf( 'MSIE' ) &&
navigator.userAgent.indexOf( 'Windows' ) != -1 ? eval( "detectFlashActiveX" +
"()" ) : false ) ) {
	gotFlash=true ;
} else { 
	gotFlash=false;
}



The reason for the Mozilla error is that the site is using Microsoft-only,
VBScript syntax on the line:

 detectFlashActiveX=(IsObject(CreateObject("ShockwaveFlash.ShockwaveFlash.5")))


Reassigning to Tech Evangelism component -

Comment 3

[Frankie]

They changed detectflash.js, seems to work now. Retest?

Comment 4

[Brant Gurganus]

I don't see anything appearing in the top Flash navigation frame.

Comment 5

[Kai Lahmann (is there, where MNG is)]

move...

Comment 6

[Bob Clary [:bc] (inactive)]

other default owner

Comment 7

[Anthony Navarro]

I get this error on the USA McDonald's site as well... I get to the main mage
but when I click on an item at the top of the menu, (nutrition Info) FireFox
locks up.

I'm on a Mac, and it works fine in the Safari browser. :-(

Comment 8

[Ian Neal]

What Build are you using of Firefox?

WFM on BuildID 2005031105 on WinXP SP2

Comment 9

[Chris Lawson (gone)]

INCOMPLETE due to lack of activity since the end of 2009.

If someone is willing to investigate the issues raised in this bug to determine whether they still exist, *and* work with the site in question to fix any existing issues, please feel free to re-open and assign to yourself.

Sorry for the bugspam; filter on "NO MORE PRE-2010 TE BUGS" to remove.

Comment 10

[Ian Neal]

Marking as WFM as it does!