Closed Bug 154934 Opened 23 years ago Closed 21 years ago

Auto-generate the GeckoVer value at build time

Categories

(SeaMonkey :: Installer, defect)

Product:
SeaMonkey
Component:
Installer
Platform:
x86
Windows NT
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: curt, Assigned: curt)

Details

Attachments

(3 files, 11 obsolete files)

Unified Patch
3.26 KB, patch
bryner
: review+
jst
: superreview+
Details | Diff | Splinter Review
GeckoVer value prior to patch
1011 bytes, image/png
Details
GeckoVer after patch
1.01 KB, image/png
Details
The string value given to the key "HCLM\Software\Mozilla\$ProductName$ $UserAgentShort$\GeckoVer" needs to change with every release. This could be generated from information available to the build scripts. See bug #109402 for details about how this can be determined.
Confirming this bug. The GeckoVer registry entry for Firefox 1.0 shouldn't be 1.0.1.
Product: Browser → Seamonkey
OK, this is my first ever stab at making fixes and creating patches, so I likely made a mistake somewhere. I think the change will accomplish the needed goal, though. If someone could try it out, that'd be cool.
Sorry, attached the wrong file.
Attachment #167484 - Attachment is obsolete: true
Attached patch Patch for XPI_JSTs\browser.jst (obsolete) — — Splinter Review
Sorry, attached the wrong file.
Attachment #167485 - Attachment is obsolete: true
Sorry, attached the wrong file.
Attachment #167486 - Attachment is obsolete: true
Attached patch Unified Patch (I think) (obsolete) — — Splinter Review
I'm pretty sure this patch combines all three patches into one.
Attached patch Attempt #2 (obsolete) — — Splinter Review
Attachment #167498 - Attachment is obsolete: true
Attached patch Unified Patch Attempt #4 (obsolete) — — Splinter Review
Attachment #167488 - Attachment is obsolete: true
Attachment #167489 - Attachment is obsolete: true
Attachment #167491 - Attachment is obsolete: true
Attachment #167495 - Attachment is obsolete: true
Attachment #167501 - Attachment is obsolete: true
Attachment #167502 - Attachment description: Attempt #4 → Unified Patch Attempt #4
Flags: blocking1.8a6?
Attachment #167502 - Attachment is obsolete: true
Attached patch Unified Patch — — Splinter Review
Attachment #167508 - Attachment is obsolete: true
OK, I made a new patch because a) the old ones were wrong (I was using the wrong variable) and b) the new one is diff'ed against CVS, so it's a better patch. I also attached images showing that the patch does work.
Attachment #168014 - Flags: review?(bryner)
I don't think we'd block the release for this but if you get reviews we'd consider taking it for Alpha6.
Flags: blocking1.8a6? → blocking1.8a6-
Attachment #168014 - Flags: review?(bryner) → review?(cmp)
Attachment #168014 - Flags: review?(cmp) → review?(bugs)
Attachment #168014 - Flags: review?(bugs) → review?(bryner)
Attachment #168014 - Flags: review?(bryner) → review+
Attachment #168014 - Flags: superreview?(jst)
Comment on attachment 168014 [details] [diff] [review] Unified Patch sr=jst
Attachment #168014 - Flags: superreview?(jst) → superreview+
Attachment #168014 - Flags: approval1.8a6?
Attachment #168014 - Flags: approval1.7.6?
Comment on attachment 168014 [details] [diff] [review] Unified Patch 1.8a6 has already wrapped up. unsetting approval request.
Attachment #168014 - Flags: approval1.8a6?
Attachment #168014 - Flags: approval1.7.6?
JST, can you check this in?
Patch checked in. Marking Fixed.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: