154942 - report failure to load stylesheet due to MIME type mismatch

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P2)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I'm going to attach a patch that reports the failure to load a stylesheet due to
a MIME type mismatch to the error console.  We've discussed this a few times,
and I finally broke down and did it.  (Do we have another bug on this somewhere?
 Oh well.)

I'll probably want to move the main added function somewhere else when I work on
localizability of CSS parser error messages.  However, for now, I'll just put it
where it's needed.

I probably need to do more magic than I just did to add a new jar.mn.  It works
on Linux, though.  (Does Mac need babysitting?)

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch, v. 1.0

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch, v. 1.1

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 89666 [details] [diff] [review]
patch, v. 1.1

>+                         NS_ConvertASCIItoUCS2("").get(), /* file name */
>+                         NS_LITERAL_STRING("").get(), /* source line */

They're both NS_LITERAL_STRING now in my tree.

Comment 4

[Boris Zbarsky [:bzbarsky]]

bug 113399 is the orig; dup whichever way is more convenient.

Do we want to use nsIRequest.name or get the URI from the nsIChannel and GetSpec
on that?  Also, is nsIRequest.name actually ASCII?  Or UTF8?

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

GetName seems to be equivalent for all the ones that actually are also
nsIChannel.  You're right that it's probably UTF8, though.  I'll fix that...

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch, v. 1.2

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch, v. 1.3

Add changes to MozillaBuildList.pm so the Mac will stay happy too.

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch, v. 1.4

Refactor a bit.  Use URI rather than Name.  Change status to error, and add
warning for case where we do load.  (I'd rather use warning and info, but
nsIScriptError doesn't have info -- we only seem to do that for generic console
messages, perhaps.)

Comment 9

[Boris Zbarsky [:bzbarsky]]

> + *  @param aErrorName     The name of a string in css.properties.
> + *  @param aParams        The parameters for that string in css.properties.
> + *  @param aParamsLength  The length of aParams.

Fix this to match the actual params the method takes and r=bzbarsky

Comment 10

[Chris Waterson]

Comment on attachment 89670 [details] [diff] [review]
patch, v. 1.4

sr=waterson

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in 2002-07-01 20:11 PDT.

Comment 12

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Madhur, if you're going to plaster "[whitebox]" over bugs, please at least don't
do it for bugs that are easily verifiable.

Comment 13

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: testcase, standards mode

Comment 14

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: testcase, quirks mode