155036 - [modern skin] Text under Delete and Junk buttons one pixel too low.

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Neil Fraser]

Open the mail/news.  Look at the 'Delete' label under the Delete button.  The
text is one pixel lower than all the other buttons on the page.  Doesn't matter
if the text is active, pressed or greyed-out.

Build ID: 2002053012

Possibly related to the fix for bug 120375?

If bugs like these are all that's left to fix, you've done fantastic work.  Well
done!

Comment 1

[Frederic Bezies]

*** Bug 155037 has been marked as a duplicate of this bug. ***

Comment 2

[Michael Gabriel]

does this bug still exist ?

Comment 3

[Neil Fraser]

Attachment: 4x magnification

> does this bug still exist?

I just downloaded 1.1, and it is definitely still there for me.  Attached a
magnified screenshot of it.

Comment 4

[[e-mail] (gone - use [e-mail] instead)]

Confirming with build 2002-10-03-08, Windows 2000, Modern theme.  Man, you have
a good eye ;-)

Comment 5

[Adam Becevello]

Confirmed on WinXP-SP1 Build ID: 2002111208

This also effects the new Junk button that was recently put on the toolbar.

Comment 6

[Neil Fraser]

Confirming that this affects the "Junk" button as well.  Changed bug title
accordingly.

Also confirmed that this affects OSX, so have changed OS to All.

Comment 7

[Adam Becevello]

Attachment: patch

Here is a patch to fix the delete and junk buttons.  The fix for the delete
button was borrowed from the patch for bug 120375 that was never checked in.
The fix for the junk button does get the job done, but there is probably a
better one.  I think the images used for those buttons are 1 pixel too tall.  
To get the button to display correctly, I copied the -moz-image-region rule
from the first entry for the delete button and used it for all instances of the
junk button.

If anyone feels like investigating whether the junk images are too tall and if
so fixing them, I think that would be the correct way to fix that button.

Comment 8

[Adam Becevello]

Comment on attachment 115819 [details] [diff] [review]
patch

Requesting review for this small fix that aligns the text of the Junk and
Delete buttons with the rest of the text on the toolbar.

Comment 9

[Adam Becevello]

Comment on attachment 115819 [details] [diff] [review]
patch

Requesting review and superreview for this small cosmetic fix that aligns the
text of the Junk and
Delete buttons with the rest of the text on the toolbar.

Comment 10

[(not reading, please use [e-mail] instead)]

we need to add the junk toolbar icons (and make them the right size) to the
monster toolbar button .gif, and then fix the .css for delete and junk.

gail do you have cycles for this?

Comment 11

[(not reading, please use [e-mail] instead)]

Comment on attachment 115819 [details] [diff] [review]
patch

I can do the r/sr.

I guess we can take the delete fix now, but for junk, we want to add the icon
to image map.

Comment 12

[Adam Becevello]

Thats fine, Do you need a new patch with only the Delete changes?  And thats
probably the best way for the Junk images to be fixed.

Comment 13

[(not reading, please use [e-mail] instead)]

abecevello, I'm getting some new icons from gail, and when I do, I'll take your
delete button fix (from the last patch) and make a new patch.

thanks again.

Comment 14

[(not reading, please use [e-mail] instead)]

Attachment: patch

Comment 15

[(not reading, please use [e-mail] instead)]

fixed.  thanks to adam for the initial patch.

Comment 16

[esther]

Using trunk builds 20030325 on winxp, macosx and linux this is fixed. Verified