155502 - Bugzilla search / query should focus summary field

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, enhancement)

Description

[Tim Powell]

When you go to the search form, no field has focus. The summary field should
have focus by default, so you can immediately start typing, just like on the
index page with quicksearch and most search engines.

This is easily accomplished with a line of javascript:

<script language="JavaScript">
<!--
document.forms['queryform'].short_desc.focus()
// -->
</script>

One place to add this is on line 30 of
bugzilla/template/en/default/search/search.html.tmpl
Change:
 onload = "selectProduct(document.forms['queryform']);"
to
 onload = "selectProduct(document.forms['queryform']);
document.forms['queryform'].short_desc.focus()"

Although this is a minor change, it will save time for all users.

Comment 1

[Joel Peshkin]

These bugs appear to be abandoned.  Retargeting to 2.20

Comment 2

[Christian Reis]

Trivial. Patch coming up.

Comment 3

[Christian Reis]

Attachment: kiko_v1: add focus() call to onLoad handler.

Tested and works. Shouldn't be any cross-browser issues -- it's the same DOM
access we use for the form selection JS.

Comment 4

[Gervase Markham [:gerv]]

This is not necessarily a good thing, for the following reason: if a page takes
a couple of seconds to load (as our query page does, being very big), and you've
already clicked somewhere and started typing, the focus gets stolen from you,
which is really irritating. Can we detect whether that has happened before
calling focus()?

(For something like www.google.com, which is tiny, it's fine.)

Gerv

Comment 5

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 144226 [details] [diff] [review]
kiko_v1: add focus() call to onLoad handler. 


Gerv has a point; this is even painful on Google sometimes.  Can we do this
right after displaying the summary field rather than after the page has been
loaded?

Comment 6

[Dave Miller [:justdave]]

With the advent of the new fulltext search, I'm usually using that when I need
to do a "quick" query on something easy.  When I go to the Advanced Query page,
I typically want to do something advanced, and most of the time it's somewhere
below the top screen of the page.  First thing I generally do when the query
page loads is hit the space bar to page down.  That gets broken if the summary
field focuses.

That said, I'd be all for focusing the "enter some words" field on the fulltext
search page, since the entire page (mostly) fits in the browser window, and the
fulltext search will be the default search page when 2.18 ships.

Comment 7

[Christian Reis]

So what do I do now?

Comment 8

[Christian Reis]

Another alternative is using inline script to focus the search form, which would
be invoked early (and not late as onLoad is). It could even be placed right
after rendering the search box (which is parsed early) to ensure nothing else
could have been focused (unless in the reload case).

How does that sound?

Comment 9

[Gervase Markham [:gerv]]

Inline script sounds like a good idea.

Gerv

Comment 10

[Christian Reis]

Attachment: kiko_v2: inline script

Glad you liked it.

Comment 11

[Christian Reis]

Attachment: kiko_v3: less braindead version for both specific and "regular" query

This is less broken, and does it for both pages.

Comment 12

[Christian Reis]

Comment on attachment 146132 [details] [diff] [review]
kiko_v3: less braindead version for both specific and "regular" query

Low-risk and a nice usability touch.

Comment 13

[Gervase Markham [:gerv]]

Comment on attachment 146132 [details] [diff] [review]
kiko_v3: less braindead version for both specific and "regular" query

r=gerv.

Gerv

Comment 14

[Dave Miller [:justdave]]

I still have my reservations on doing this on the advanced query page, but I
suppose we can back it out later if we get a lot of complaints.

Comment 15

[Dave Miller [:justdave]]

checked in for kiko, since he's off wandering Europe somewhere. :)

Checking in template/en/default/search/form.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/form.html.tmpl,v 
<--  form.html.tmpl
new revision: 1.23; previous revision: 1.22
done
Checking in template/en/default/search/search-specific.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/search-specific.html.tmpl,v
 <--  search-specific.html.tmpl
new revision: 1.6; previous revision: 1.5
done