Closed
Bug 155918
Opened 22 years ago
Closed 21 years ago
inefficent use of search and match in linkToolbarHandler.js
Categories
(SeaMonkey :: UI Design, defect)
SeaMonkey
UI Design
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: neil, Assigned: drbrain-bugzilla)
References
Details
(Keywords: perf, polish)
Attachments
(1 file, 1 obsolete file)
|
2.20 KB,
patch
|
neil
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
search and match shouldn't be used when you can use test. you don't need to lower case before testing, use /i instead. you don't need separate tests, use | instead. you don't need to test for ^|\W or \W|$, use \b instead.
|
Reporter | |
Comment 1•22 years ago
|
||
|
|
Reporter | |
Comment 2•22 years ago
|
||
Bah, the fix to bug 102897 crept in. Too many patches :-( -- "There are just too many notes." - Amadeus
|
||
Comment 4•21 years ago
|
||
Attachment #90320 -
Attachment is obsolete: true
|
|
||
Updated•21 years ago
|
Attachment #126055 -
Flags: review?(neil.parkwaycc.co.uk)
|
|
||
Updated•21 years ago
|
Attachment #126055 -
Flags: superreview?(jst)
|
|
Reporter | |
Comment 5•21 years ago
|
||
Comment on attachment 126055 [details] [diff] [review] fixed and updated patch Apparently i++ is bad in JS, change that to ++i for r=
Attachment #126055 -
Flags: review?(neil.parkwaycc.co.uk) → review+
|
|
Reporter | |
Comment 6•21 years ago
|
||
New information: i++ is not bad in JS, it's a habit I picked up from glazman :-)
|
||
Comment 7•21 years ago
|
||
Comment on attachment 126055 [details] [diff] [review] fixed and updated patch sr=jst
Attachment #126055 -
Flags: superreview?(jst) → superreview+
|
|
Reporter | |
Comment 8•21 years ago
|
||
Fix checked in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
|
||
Updated•20 years ago
|
Product: Core → Mozilla Application Suite
You need to log in
before you can comment on or make changes to this bug.
Description
•