15607 - nsIPluginManager2::FindProxyForURL() returns E_NOTIMPL

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect, P3)

Description

[Robert H. Yang]

The method nsIPluginManager2::FindProxyForURL() returns E_NOTIMPL.  This is
obviously problematic when trying to do proxy resolution.

Comment 1

[edburns]

Andrew,

I'm working on this, so you can assign it to [e-mail] if you like.

I just don't want to duplicate effort.

Comment 2

[av (gone)]

Reassigning. Thanks.

Comment 3

[edburns]

I've got a fix for this, but I'm experiencing problems with
nsIProxy::GetProxyHost.  See Message-ID: <7te54m$q7m$[e-mail]>
on n.p.m.netlib.  Any help would be greatly appreciated.

Comment 4

[edburns]

Attachment: Fix to bug 15607

Comment 5

[edburns]

Andrei Volkov,

As module owner, can you code review my patch and grant me permission to check
it into the tree as a fix for this bug?  If I don't hear from you by Tuesday,
I'll reassign the bug to you.

Thanks,

Ed

Comment 6

[av (gone)]

Looks fine to me. Please go ahead and check it in.

Comment 7

[edburns]

This fix requires that the user has entered the proxy information into the
mozilla preferences file.

Comment 8

[Eli Goldberg]

[e-mail], could you possibly verify this bug, by confirming that Ed
Burns's patch correctly addresses this issue? Thanks!

Comment 9

[Eli Goldberg]

[QA Assigning to [e-mail], per e-mail mention that he'd try to verify it
with Ed Burns.]

Comment 10

[Robert H. Yang]

[e-mail]: Tested out Ed's fixes yesterday.  They're great, but we
still need support for the proxy bypass list and auto-configuration, right ?

Comment 11

[edburns]

ryang: I agree that we need to add in code for "go direct for local addresses",
but I don't know what we need to do for auto-configuration.  I'm going to
create another bug for accountability purposes, leave this one cleared.

Comment 12

[edburns]

Attachment: nsCOMPtr friendly version of fix.

Comment 13

[edburns]

With shaver and scc's advice, I have removed the native interface pointer in
this fix and replaced it with an nsCOMPtr.  Could someone please review today's
patch so I may check it in?