1561930 - Calls to Cu.reportError() from chrome JS shouldn't be treated as "web content" messages

Status: RESOLVED FIXED

(DevTools :: Console, defect, P1)

Description

[:Gijs (he/him)]

What were you doing?

1. Open Firefox with a clean profile
2. Open regular devtools
3. Enable chrome/add-on debugging in the devtools settings
4. open the browser console (accel-shift-j)
5. Run Cu.reportError("Hello");

What happened?

The hello message was not visible. It is only visible once you tick "Show content messages".

What should have happened?

The hello message should have been visible. It did not come from content and should not be filtered by that checkbox.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Thanks for the report Gijs!
Eden, any idea what's going on?

Comment 2

[Eden Chuang[:edenchuang]]

Sorry for the late response. Working on it.

Comment 3

[Eden Chuang[:edenchuang]]

Attachment: Correct the wrong attribute isFromChromeContext value for chrome context messages from Cu.reportError

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1c1e27b9d73b
Correct the wrong attribute isFromChromeContext value for chrome context messages from Cu.reportError r=baku

Comment 5

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/1c1e27b9d73b

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

Thanks Eden!