156505 - xpcshell is missing a fflush

Status: VERIFIED FIXED

(Core :: XPConnect, defect)

Description

[timeless]

os/2 4.52, nightly from today

I ran xpcshell and didn't get a prompt which confused me, i thought it was still
loading...


[C:\drop\mozilla-nightly]xpcshell
1
js> 1
1+1
js> js> 2

the prompt isn't appearing until after the input or something..
i guessed fflush and mkaply confirms that it fixes it.

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Fix

Added fflush in the prompt case.

Should we fflush after each fprintf?

Comment 2

[David Bradley]

Comment on attachment 90640 [details] [diff] [review]
Fix

r=dbradley

It's ambiguous enough that adding this is probably the right thing to do.
There's a good discussion at:

http://groups.google.com/groups?q=printf+stdin+buffer+line+%22interactive+devic
e%22+console&hl=en&lr=&ie=UTF-8&oe=UTF-8&selm=PSHUANG.93May28210433%40ninja.mit
.edu&rnum=1

No, we shouldn't need this on every fprintf. The one for the prompt should
suffice, since it's always the last thing printed before input is asked, thus
all previous output will be flushed as well

Comment 3

[David Bradley]

Since you did the patch, do you want to see that it gets in. Feel free to throw
it back my way if you want.

Comment 4

[John Bandhauer]

Would this not also be a problem in js.c too? It is good to keep the common
portions of these two apps in sync.

Comment 5

[Mike Kaply [:mkaply]]

Attachment: Merged patch per jband

Comment 6

[Mike Kaply [:mkaply]]

Attachment: Let's try this again

Comment 7

[Mike Kaply [:mkaply]]

Comment on attachment 115404 [details] [diff] [review]
Let's try this again

brendan, could you r/sr this one?

It's an easy change.

thanks

Comment 8

[Mike Kaply [:mkaply]]

Fix checked in.

Comment 9

[Phil Schwartau]

Checkin verified -