156871 - javascript REFRESH script doesn't work in Mozilla

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P4)

Description

[Egg]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.0.0) Gecko/20020530
BuildID:    2002053012

The javascript refresh script doesn't function at all in Mozilla:
javascript:history.go()

An example of this is at:
http://javascript.internet.com/buttons/refresh-button.html

Reproducible: Always
Steps to Reproduce:
1. visit url (http://javascript.internet.com/buttons/refresh-button.html)
2. click the button as described on page
3. sigh

Actual Results:  nothing :(

Expected Results:  refreshed the page

As a button or a text link, this script fails to function at all.

Comment 1

[Christopher Hoess (gone)]

->DOM0. What is history.go()?

Comment 2

[José Jeria]

Shouldn't it be 
history.go(0);

to reload the page?

Comment 3

[Egg]

A HREF='javascript:history.go()' doesn't work (an anchor take).

Comment 4

[Johnny Stenback (:jst)]

Does NS4x and IE let you call history.go() w/o any arguments?

Comment 5

[José Jeria]

IE yes, Netscape 4 no

Comment 6

[Johnny Stenback (:jst)]

Hmm, do we know of any real sites that are broken due to this?

Comment 7

[Bob Clary [:bc] (inactive)]

I haven't seen any sites with problems due to this. Doron/Marcio?

Comment 8

[Philip White]

Valid Javascript requires a parameter in history.go()... it doesn't even make
sense otherwise.  Where is the browser supposed to go, if the script doesn't
tell it?

A Google search indicates that one should use either history.go(0) or
location.reload(true) to refetch a webpage.

Because of this, I am resolving this bug as WONTFIX, since history.go() doesn't
seem like valid Javascript member function.  If anyone can find Javascript
specifications that indicate otherwise, feel free to reopen it.

Comment 9

[Johnny Stenback (:jst)]

Not that I know that this really matters, but it's easy enough to fix, so I'm
gonna attach a trivial patch that makes history.go() === history.go(0), just for
compliance with IE.

Comment 10

[Johnny Stenback (:jst)]

Attachment: Make history.go() same as history.go(0)

Comment 11

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 116887 [details] [diff] [review]
Make history.go() same as history.go(0)

r=sicking, though i'd be perfectly fine with not landing this too

Comment 12

[Peter Van der Beken [:peterv]]

Comment on attachment 116887 [details] [diff] [review]
Make history.go() same as history.go(0)

sr=peterv, though i'd be perfectly fine with not landing this too

Comment 13

[Johnny Stenback (:jst)]

Fix checked in, for better or worse...

FIXED.