156876 - "Quote Message" menu item doesn't work on recently trunk

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect)

Description

[Pete Zha]

The contractID and call method of nsIWindowMediator has been changed. So, "Quote
Message" doesn't work.

Comment 1

[Pete Zha]

Attachment: patch

Use new contract ID and call style to call the nsIWindowMediator.

Comment 2

[Jean-Francois Ducarroz]

Comment on attachment 90949 [details] [diff] [review]
patch

R=ducarroz

Comment 3

[David :Bienvenu]

Comment on attachment 90949 [details] [diff] [review]
patch

sr=bienvenu, thanks. It might makes sense to grep for
datasource;1?name=window-mediator to see if anyone else is still using this -
this is the second bug I've seen on this issue.

Comment 4

[Jean-Francois Ducarroz]

there is all the occurance in Mozilla:
/extensions/inspector/resources/content/inspector.js, line 52 -- const
kWindowDataSourceCID = "@mozilla.org/rdf/datasource;1?name=window-mediator";
/xpfe/communicator/resources/content/tasksOverlay.js, line 166 -- var
windowManagerDS =
Components.classes['@mozilla.org/rdf/datasource;1?name=window-mediator'].getService(nsIWindowDataSource);
/xpfe/communicator/resources/content/tasksOverlay.js, line 193 -- var
windowManagerDS =
Components.classes['@mozilla.org/rdf/datasource;1?name=window-mediator'].getService(nsIWindowDataSource);
/mailnews/compose/resources/content/MsgComposeCommands.js, line 640 -- var
mailWindow =
Components.classes["@mozilla.org/rdf/datasource;1?name=window-mediator"]

Comment 5

[Jean-Francois Ducarroz]

and there is more in the commercial tree! maybe we should open a new bug for
those...

Comment 6

[David :Bienvenu]

Yes, I think we should open a new bug and perhaps assign it to the person who
changed this. 

Comment 7

[Jean-Francois Ducarroz]

Pete, do you need me to check in the fix?

Comment 8

[Jean-Francois Ducarroz]

the fix for bug 132175 caused that regression...

Comment 9

[Jean-Francois Ducarroz]

I filed bug 156956 and another one for the commercial tree

Comment 10

[Pete Zha]

Seems like we nee approval to check in. I will ask for it soon.

Comment 11

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 90949 [details] [diff] [review]
patch

a=roc+moz for TRUNK

Comment 12

[Pete Zha]

I have checked in it.
Thanks all

Comment 13

[esther]

using trunk build 20021121 on winxp, macosx and linux Quote message is working now
verified