157067 - Inconsistency in appearance of "Move Up" and "Move Down" buttons

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Tuukka Tolvanen (sp3000)]

linux trunk cvs 2002-07-11

"Move Up" and "Move Down" buttons in:
    - nav>languages pref panel have arrow images and text labels;
    - mail>tools>filters dialog have text labels but no arrow images;
    - mail>view>coding>customize dialog have arrow images but no text labels.

I suppose it would be nice to add the text labels to the
mail>view>coding>customize buttons, and class="(up|down)" for the
mail>tools>filters buttons to get the arrows.

Comment 1

[Tuukka Tolvanen (sp3000)]

Oh, yeah, the arrows may not be there in classic because of bug 139573.

Comment 2

[Matthew T (active 1999-2002)]

This is semi-related to bug 45412.

Comment 3

[Tuukka Tolvanen (sp3000)]

Attachment: screen, shot.

Comment 4

[timeless]

uid is being phased out.

Comment 5

[Tuukka Tolvanen (sp3000)]

Attachment: use arrows in mail filter dialog move up/down buttons

This should fix the only remaining bit.

Comment 6

[(not reading, please use [e-mail] instead)]

I'm not sure about this.

first, what's the accesskey?  (you've made it so I have to guess what it is, or
worse, none at all.)

if we were to take it, we'd want to remove these (from xul and dtd.)

label="&reorderUpButton.label;" accesskey="&reorderUpButton.accesskey;" 
label="&reorderDownButton.label;" accesskey="&reorderDownButton.accesskey;" 

I think the accesskey issues is important, and argue that the customize
character coding dialog is wrong, but we should still make all three look the
same, have the same labels, *and* have the same accesskeys

Comment 7

[jglick]

I'd recommend "Move Up" and "Move Down" for all, so we have the visible access
keys. (I don't think the text plus the arrows are nec).

Comment 8

[Stefan Borggraefe]

Attachment: Makes buttons and access keys in Filter List consistent with the rest of Seamonkey

Also changes the accesskey of "Run selected filters on" from "i" to "c",
because i is very narrow which makes it hard to see the accesskey.

Comment 9

[Stefan Borggraefe]

Comment on attachment 145778 [details] [diff] [review]
Makes buttons and access keys in Filter List consistent with the rest of Seamonkey

Aaron, are you doing reviews again?

Comment 10

[Aaron Leventhal]

Comment on attachment 145778 [details] [diff] [review]
Makes buttons and access keys in Filter List consistent with the rest of Seamonkey

Yes, I'm doing reviews again. However, I think the rules for front end work are
that you have to run it by the specific front-end reviewers. For Seamonkey,
that means [e-mail] or [e-mail].

I don't know if either of them are superreviewers.

Here's an r= for what it's worth.
Thanks for fixing this :)

Comment 11

[Stefan Borggraefe]

(In reply to comment #10)
> (From update of attachment 145778 [details] [diff] [review])
> Yes, I'm doing reviews again. However, I think the rules for front end work are
> that you have to run it by the specific front-end reviewers. For Seamonkey,
> that means [e-mail] or [e-mail].

I always thought it is enough if a module owner or peer either reviewed or
super-reviewed a patch. I just chatted with Neil about this and he said this is
correct basically.

Comment 12

[Stefan Borggraefe]

Comment on attachment 145778 [details] [diff] [review]
Makes buttons and access keys in Filter List consistent with the rest of Seamonkey

Asking a MailNews peer for sr.

Comment 13

[Stefan Borggraefe]

Fix checked in.

Comment 14

[Stefan Borggraefe]

There is another dialog in the Import-Wizard in MailNews that has Move Up and
Move Down buttons that I missed.

Reopening for the supplemental patch to come.

Comment 15

[Scott MacGregor]

the 2004/04/09 patch is fixed on the aviary1.0 branch

Comment 16

[Stefan Borggraefe]

Attachment: Change the buttons in the Customize Sidebar dialog

I overlooked the Up/Down-buttons in the Customize Sidebar dialog. This patch
changes these buttons to the style of the other Up/Down-buttons.

I also corrected the case of the access keys and of the button "Find more
tabs..." in the DTD. The string "sidebar.customize.reorder.label" was unused
since 1999.

Comment 17

[Alec Flett]

Comment on attachment 149921 [details] [diff] [review]
Change the buttons in the Customize Sidebar dialog

sr=alecf

Comment 18

[Stefan Borggraefe]

I just checked in the last patch.

FIXED for real. :-)