157196 - ScriptableObject needs custom serialization implementation

Status: VERIFIED FIXED

(Rhino Graveyard :: Core, defect)

Description

[Igor Bukanov]

Currently ScriptableObject uses the standard Java support for serialization of
its data structures from hashtable implementation. But this does not work
properly as long as the slots array contains deleted entries marked with the
REMOVED slot tag. The standard Java de-serialization restores such entries to a
reference to a newly allocated object which != REMOVED. Such entries will stick
with hashtable forever and at some point will violate internal sanity checks.

In addition, the standard serialization waists storage as it takes room to store
empty/deleted slots.

Comment 1

[Igor Bukanov]

Attachment: Custom serialization of ScriptableObject

The patch marks slots array as transient and adds writeObject/readObject that
write/read only existing slots in the hashtable. I had also to change
implementation of sealObject to set count to -1 - count so it would be possible
to know amount of existing slots without searching throw the slots array even
in the sealed object.

Comment 2

[Igor Bukanov]

Attachment: Stress test for ScriptableObject serialization

Save it as SerTest.java

Comment 3

[Igor Bukanov]

Fixed: I commited the patch as it passes the above stress test.

Comment 4

[Phil Schwartau]

Verified FIXED. Before the patch, the above testcase failed as follows:

Exception in thread "main" java.lang.RuntimeException: FAILED!
        at SerTest.test(SerTest.java:36)
        at SerTest.main(SerTest.java:12)



After the patch:

PASSED

Comment 5

[Igor Bukanov]

Targeting as resolved against 1.5R4