157503 - Crash:Thread pane confused after undo delete a mail.

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Antonio.Xu]

Mozilla 1.0
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.0.0) Gecko/20020710
steps to reproduce:
I think this bug was very important,I can reproduce on mozilla1.0 branch and 
trunk. The bug will arise some problem of showing and crash. We should try to 
fix it before NS7 is released.
1. open netscape mail
2. copy some associated emails to a new folder
2. sort msg header by thread in new folder
3. find any msg thread
4. click [+] button in front of msg subject, to deploy the thread
5. delete the first email in the group, please don't group the thread
6. undo delete(hit Ctrl+Z)
Actual Results:  Thread pane was confused, if you click the blank email 
subject, mozilla would crash.

Expected Results:  Thead pane should showing correctly

Comment 1

[Damir Perisa]

> if you click the blank email 
> subject, mozilla would crash.

have a look at the 'topcrash' bug 156630
seem NC7/MOZ1.0+ still have this problem with empty subject lines

Comment 2

[Antonio.Xu]

I will try to fix it.

Comment 3

[David :Bienvenu]

Attachment: proposed fix for crash

this fixes the crash on selecting the blank msg header. The other part of the
problem is to fix undoing the delete so that it inserts the header correctly in
the view.

Comment 4

[David :Bienvenu]

Cavin, can I get an r= for this first patch? thx.

Comment 5

[Cavin Song]

Comment on attachment 91357 [details] [diff] [review]
proposed fix for crash

r=cavin.

Comment 6

[(not reading, please use [e-mail] instead)]

Comment on attachment 91357 [details] [diff] [review]
proposed fix for crash

sr=sspitzer

Comment 7

[Antonio.Xu]

Thank you Bienvenu's patch
I think we still fix another problem showing problem,when we delete the first 
email in a thread.I will find a way to resolve it.

Comment 8

[David :Bienvenu]

I have a fix for the other problem, which I'll attach in a moment.

Comment 9

[David :Bienvenu]

Attachment: proposed fix for view problem

problem was that we were not setting the insert index for the new header
correctly. Navin, can I get a r=? thx.

Comment 10

[(not reading, please use [e-mail] instead)]

Comment on attachment 91546 [details] [diff] [review]
proposed fix for view problem

sr=sspitzer

Comment 11

[David :Bienvenu]

cavin, can I get an r= for the second patch? (I forgot that you reviewed the
first patch)

Comment 12

[Asa Dotzler [:asa]]

Comment on attachment 91357 [details] [diff] [review]
proposed fix for crash

a=asa (on behalf of drivers) for checkin to 1.1

Comment 13

[Cavin Song]

Comment on attachment 91546 [details] [diff] [review]
proposed fix for view problem

r=cavin.

Comment 14

[Antonio.Xu]

Hi Bienvenu,I have tested your new patch,but I found it can not fix the bug 
completely.If I expand two thread in a folder, then I delete the first email of 
the first thread, It will showing incorrectly,when I undo delete.

Comment 15

[Antonio.Xu]

Attachment: patch version 1.00,please r=? & sr=?

I found when we try to collapse a thread, nsMsgDBView will remove all child of
thread. When we undo delete the first email of the thread, It will collapse the
thread, but the threadcound has been added due to adding a new email, dbview
will try to remove more child of the thread, then dbview will remove wrong
child. My fix can resove this problem.

Comment 16

[Antonio.Xu]

I found a new problem:
steps to reproduce:
1. open mozilla mail
2. copy some associated emails to a new folder
2. sort msg header by thread in new folder
3. find any msg thread
4. click [+] button in front of msg subject, to deploy the thread
5. delete a random email in the group, please don't collapse the thread
6. undo delete(hit Ctrl+Z)
7. close mozilla
8. open mozilla mail again
9. open the new folder
10. delete mail and undo delete like the step above
Actual Results:  Thread pane was confused.
Expected Results:  Thead pane should showing correctly
I will research the new problem of this bug,I hope i can find a way to fix it.I 
really think the bug is very serious bug. we should try to fix it before ns7 
release.

Comment 17

[David :Bienvenu]

Comment on attachment 91640 [details] [diff] [review]
patch version 1.00,please r=? & sr=?

At first look, I don't think this approach is correct. It's basically trying to
recover from an earlier problem, and the problem should be fixed at that place.

Comment 18

[David :Bienvenu]

Attachment: proposed fix

a better fix is to delay the collapse and expanding of the thread until the
view has the correct number of messages in the thread (so that collapsing the
thread will do the right thing). I've tried this patch and it seems to work
better, but I'd appreciate it if you could try it out, Antonio and see if you
still see problems.

Comment 19

[Antonio.Xu]

Thanks for David's patch, I have verified your patch, It can resolve two 
problems of the bug and works fine. I didn't see any problem when I verified 
your patch.
Feeling very happy to help you

Comment 20

[David :Bienvenu]

thank you for your help, Antonio. Fixed on trunk.

Comment 21

[Antonio.Xu]

patch checked into NETSCAPE_7_0_OEM_BRANCH 

Comment 22

[grylchan]

quick question for david or antonio.

in the commercial trunk:
2002-09-19-08-trunk/ NT 4.0
2002-09-20-08-trunk/ mac 9.2.2
2002-09-20-08-trunk/ linux 2.2, red hat 7.0

is this a bug:
you have thread pane view with 2 mesgs in the inbox
so it looks like
  mesg one
    |
    --mesg two

If I delete 'mesg one', I see 'mesg two' is selected in thread pane
and header/body in the mesg pane shows 'mesg two'. if I undo the
delete, I see 'mesg one' appear in the thread pane and it looks
selected to me. But when I view the mesg pane, it still shows
the header/body of 'mesg two'.

This a new bug? old bug?

Should I file a new one.

I couldn't replicate any crashes using Antonio's test cases
so thats fixed.

Comment 23

[grylchan]

using commerical
2003-01-02-05-trunk Xp
2003-01-02-08-trunk Mac OS 10.1.2, linux 2.2

verified in Antonio's first comment and comment 16
that no crash occurs when deleteing a mesg in thread pane
and undoing the delete.

minor problem I see is still in my previous comment, comment 22
but will file a new bug on that one.

marking as verified.