158447 - Advanced autocomplete prefs dialog needs Help button

Status: VERIFIED FIXED

(SeaMonkey :: Help Documentation, defect)

Description

[Blake Ross]

Build ID: new trunk

Steps to Reproduce:
1. Open the Preferences dialog.
2. Go to the Navigator > Smart Browsing preference panel.
3. Hit 'Advanced...'

There should be a Help button in this window, since we do have help content for
the prefs in it.

Comment 1

[Wesha]

Confirmed.

Comment 2

[Brant Gurganus]

to documentation > user

Comment 3

[Ian Oeschger (gone)]

accepting

Comment 4

[Ian Oeschger (gone)]

moving stuff over to an outside-the-firewall email for the time being, looking
for people to pick these Help and doc bugs up for me.

Comment 5

[R.J. Keller]

Why is this in Doc:User? Moving back to Browser:Help

Comment 6

[Daniel Wang]

Attachment: patch

Uncompiled, untested, but should work

Comment 7

[Daniel Wang]

Comment on attachment 131872 [details] [diff] [review]
patch

Keller, does this patch work for you? (please ignore the
cs_nav_prefs_advanced.html part)

Comment 8

[R.J. Keller]

Comment on attachment 131872 [details] [diff] [review]
patch

Daniel, I'm going to ask that Neil review this. The reason is because this goes
into XP-Apps, and I can't review in XP Apps. This will require super-review
also. You'll probably have the best chances with alecf.

Sorry.

Comment 9

[R.J. Keller]

--> Daniel Wang

Comment 10

[[e-mail]]

Comment on attachment 131872 [details] [diff] [review]
patch

Assuming you only need me to review the XUL, otherwise rerequest.

>+        ondialoghelp="return doHelpButton(event)"
Sadly you copied the only incorrect existing code. Nobody's doHelpButton
function actually uses an event, but you "fixed" your function by adding a
useless parameter. Also a ; at the end would be nice as per the line above.

>-  ]]></script>
>+ ]]></script>
Make sure that this doesn't get checked in like this.

Comment 11

[Daniel Wang]

Attachment: patch - retry

Comment 12

[[e-mail]]

Comment on attachment 133026 [details] [diff] [review]
patch - retry

>         ondialogaccept="return onAccept();" 
>+        ondialoghelp="doHelpButton()"
Still missing the ; :-/

Comment 13

[Daniel Wang]

Comment on attachment 133026 [details] [diff] [review]
patch - retry

Blake, can I get a sr for the xul part?

Comment 14

[R.J. Keller]

Comment on attachment 133026 [details] [diff] [review]
patch - retry

let's do alecf. blake is a very hard person to get reviews from.

Comment 15

[Alec Flett]

Comment on attachment 133026 [details] [diff] [review]
patch - retry

sr=alecf

Comment 16

[Daniel Wang]

rlk, what's holding this up?

Comment 17

[R.J. Keller]

ah! sorry about that Daniel! Didn't notice this bug got super-review!

Fix checked in.

Comment 18

[Daniel Wang]

reopen. got a js error :-(

Comment 19

[Daniel Wang]

Attachment: fix js error

Comment 20

[R.J. Keller]

Comment on attachment 138887 [details] [diff] [review]
fix js error

Daniel, this is outside my module, so I can't give review.

Asking Neil for review instead.

Comment 21

[[e-mail]]

Comment on attachment 138887 [details] [diff] [review]
fix js error

>-
Bleh.

>+  <script type="application/x-javascript" src="chrome://communicator/content/pref/pref-help.js"/>
I think you need the script that declares openHelp, and it's not this one...

Comment 22

[Daniel Wang]

Attachment: fix js error (2nd try)

Comment 23

[[e-mail]]

Comment on attachment 138915 [details] [diff] [review]
fix js error (2nd try)

I'd prefer to have more spacing rather than less...

Comment 24

[Alec Flett]

Comment on attachment 138915 [details] [diff] [review]
fix js error (2nd try)

that's easy. sr=alecf

Comment 25

[R.J. Keller]

Fix checked in.