15892 - pluglets do not work with multiple MIMEtypes definition

Status: VERIFIED FIXED

(Core Graveyard :: Java-Implemented Plugins, defect, P3)

Description

[Igor Kushnirskiy]

If we have more than one mime type in our pluglet manifest file
(for exampe:   mime1;mime2;mime3::) only first is working

Comment 1

[Igor Kushnirskiy]

Attachment: Fix for bug 15892

Comment 2

[Igor Kushnirskiy]

The reason of this bug is:
---
Pluglet::Compare method
***************
*** 163,169 ****
          }
          p1 = p2 ;
          if (p2 != NULL) {
              p2 = strchr(p2,';');
              p1++;
          }
      }
--
p2 is pointing to ';'. After we  call strchr(p2,';') we will point to the
same location because the first occurrence of ';' would the first character.
So we never get second token and we will have infinite loop.

Suggested fix:
we need to increment p2 before calling strchr(p2,';')
(see attachments)

This fix was approved by [e-mail]

Comment 3

[Vladimir Strigun]

Verified with mozilla branch Netscape61_RELEASE and blackwood branch 
JAVADEV_6_1_20010831 under Sparc Solaris 2.8.
Pluglets worked with any of defined in manifest mime types. 

Comment 4

[Alexei V. Mokeev]

VERIFIED