158941 - install items should be a <dialog> not a <window>

Status: RESOLVED FIXED

(Core Graveyard :: Installer: XPInstall Engine, defect)

Description

[timeless]

sirlurxalot discovered this while using the sidebar on right css from
customizing unix http://www.mozilla.org/unix/customizing.html

<dialog>
http://www.xulplanet.com/tutorials/xultu/elemref/ref_dialog.html
<window>
http://www.xulplanet.com/tutorials/xultu/elemref/ref_window.html

Comment 1

[timeless]

conversion is simple and can be extrapolated from reading any <dialog> which was
migrated, to find one, i loaded:
http://lxr.mozilla.org/seamonkey/search?string=%3Cdialog
clicked on a hit, clicked on cvs blame
and then clicked on the blame for <dialog> which gave me:
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/editor/ui/dialogs/content&command=DIFF_FRAMESET&file=EdNamedAnchorProps.xul&rev2=1.47&rev1=1.46

-this help is provided because we're recruiting mozillazine people to do patches.

Comment 2

[timeless]

whoops http://lxr.mozilla.org/seamonkey/search?string=%5C%3Cdialog (lxr needs a
patch to sanely handle <, until then you have to prefix it and other chars w/ '\')

Comment 3

[timeless]

Attachment: one visual result of the bug

Comment 4

[Sebastian Fernandez]

Attachment: Changed to dialog

Not sure I got the bindings to JS right. In particular not sure if
ondialogaccept should map to onOk()

Comment 5

[Sebastian Fernandez]

Attachment: Same patch as before, but fixed the DOCTYPE

Comment 6

[Alec Flett]

Comment on attachment 92462 [details] [diff] [review]
Same patch as before, but fixed the DOCTYPE

sr=alecf

what is the visual result of fixing this bug?

Comment 7

[Sebastian Fernandez]

It corrects the problem shown in timeless' attachment.

Comment 8

[Sebastian Fernandez]

Taking ownership of bug.

Comment 9

[Jesse Ruderman]

Does this change make the escape key cancel?

Comment 10

[[e-mail]]

Comment on attachment 92462 [details] [diff] [review]
Same patch as before, but fixed the DOCTYPE

This patch is incomplete. You should remove dialogOverlay, doSetOKCancel and
onCancel, and fix onOk.
/me idly wonders why the url has crop="end"...

Comment 11

[Stefan Borggraefe]

This was fixed as part of the checkin for bug 214721.