Closed Bug 159413 Opened 22 years ago Closed 22 years ago

Pipelining "WARNING" should be revised...

Categories

(SeaMonkey :: Preferences, defect, P2)

Tracking

(Not tracked)

VERIFIED FIXED
mozilla1.0.1

People

(Reporter: darin.moz, Assigned: darin.moz)

References

Details

(Whiteboard: [adt2 RTM] [ETA 07/27])

Attachments

(1 file, 1 obsolete file)

The pipelining "WARNING" message really shouldn't include the phrase
"experimental feature" any longer.  Kevin suggested "advanced feature" instead,
and I think that makes good sense.

Here's his rewording (repeated here, originally from bugscape bug 17549):

 "WARNING: pipelining is a feature designed to improve page-load performance but
  is not fully supported by some web servers and proxies. This feature is for
  advanced users only."
Attached patch v1 patch (obsolete) — Splinter Review
Severity: normal → major
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: [adt2 RTM]
Target Milestone: --- → mozilla1.0.1
Keywords: nsbeta1adt1.0.1, nsbeta1+
The use of "Warning" sounds dire, but I gather it's appropriate (as opposed to
"Note" or "Important") if the user perceives data loss. We normally reserve
"Warning" to matters of data loss or system corruption.

The wording it too lengthy. Suggested rewrite (note capitalization change, too): 

 "WARNING: Pipelining may improve page-load performance but
  is not fully supported by some web and proxy servers. This feature is for
  advanced users only."
Comment on attachment 92775 [details] [diff] [review]
v1 patch

r=gagan
Attachment #92775 - Flags: review+
what message are we going with here, the one Steve suggests, or somehting else?
pls advise ...
Blocks: 143047
I defer to Steve's expertise here.
yeah, the new wording (in comment #3) sounds better to me as well.  new patch
forthcoming...
Attached patch v2 patchSplinter Review
reworded per Steve's suggestion.
Attachment #92775 - Attachment is obsolete: true
Keywords: approval
Whiteboard: [adt2 RTM] → [adt2 RTM] [ETA 07/27]
QA Contact: sairuh → benc
Adding adt1.0.1+ on behalf of the adt for checkin to the 1.0 branch.  Please get
drivers approval before checking in. When you check this into the branch, please
change the mozilla1.0.1+ keyword to fixed1.0.1

Keywords: adt1.0.1adt1.0.1+
Pipelining is an HTTP feature -> qa to Tom.

Should we just move the bug to HTTP as well?
QA Contact: benc → tever
Comment on attachment 92828 [details] [diff] [review]
v2 patch

forwarding r=gagan, sr=rpotts
Attachment #92828 - Flags: superreview+
Attachment #92828 - Flags: review+
ok, fixed1.0.1
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
verified 8/13/02 builds - winNT4, linux rh6, mac osX

needs tested on trunk yet
Keywords: verified1.0.1
Keywords: fixed1.0.1
Shouldn't this be reopened as it was never fixed on the trunk?
no, because this shouldn't be on the trunk (pipelining works ...)
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: