159466 - Options under "Copies and folders" are active when they should be disabled

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Account Configuration, defect)

Description

[Adam Becevello]

Moz 1.1b Build ID: 2002072104

This is kind of hard to explain.  This happens in the account manager in mail,
under Drafts and Templates in the "Copies and folder" option under any account.
 The drop-down box for the "Other" option is active when it should be disabled.
 Clicking on the radio button to activate "Other" will disable the first option.
 If you then click back to the first option everything work correctly.  This
happens each time the Mail Account manager is opened.  I will attach screenshots
to help with the explaination.

Comment 1

[Adam Becevello]

Attachment: The shows what is wrong

This shows what is the problem.  The "Other" control is active when the first
option should be the only one available.

Comment 2

[Adam Becevello]

Attachment: This shows what it should look like

This shows what it should look like.  When the first option is selected, the
second one is disabled, and vice versa.

Comment 3

[Benjamin Bock]

it's the same in Mozilla 1.1 (Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US;
rv:1.1) Gecko/20020826)

if Bug#91551 (http://bugzilla.mozilla.org/show_bug.cgi?id=91551) would be done
this fixing this bug would be superfluous.

Comment 4

[Malte Rücker (mbr)]

*** Bug 218438 has been marked as a duplicate of this bug. ***

Comment 5

[Douglas]

Bug persists in Mozilla build 2004020608. I checked bug 91551 but no one is
working on it.

Comment 6

[Stefan Borggraefe]

Attachment: Patch

When these options were not locked the disabled attribute was removed from the
elements (after they were correctly disabled before). This is not needed and
causes the bug.

It is enough to disable the element when the option is locked and do nothing
when it is not locked.

Comment 7

[[e-mail]]

Comment on attachment 147828 [details] [diff] [review]
Patch

Ugh, what ugly code... cvs blames racham r=naving for making eddyk r=bhuvan
disable the radio elements separately, sigh...

Comment 8

[[e-mail]]

Attachment: Possibility of cleanup

Just to give you an idea of the sort of cleanup that should be possible...

Note that I've only done basic testing with this to ensure that the right
things get selected and enable/disable as you switch panels and accounts.

Comment 9

[Stefan Borggraefe]

This bug is fixed. I filed bug 243084 for additional cleanup of am-copies.js.

Comment 10

[Stefan Borggraefe]

Comment on attachment 147828 [details] [diff] [review]
Patch

Asking for approval. This patch makes sure that the UI elements of the "Copies
& Folders" pane are correctly disabled. Very low risk.

Comment 11

[chris hofmann]

Comment on attachment 147828 [details] [diff] [review]
Patch

a=chofmann for 1.7

Comment 12

[Karen Huang]

Verified as fix on latest 1.7 branch 06-18 build.
Changing keywords from fixed1.7 to verified1.7.
Leave this bug status "as is" until this bug be verified on trunk again...