159747 - everything is inherited into the new boxes in a <marquee>

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Kai Lahmann (is there, where MNG is)]

..even properties, which shouldn't, as padding, background-image, border, margin
or width/height

Comment 1

[Doron Rosenberg (IBM)]

Minimal testcase:
http://www.nexgenmedia.net/bug3/marquee.html

Comment 2

[Wesha]

I beleive it's because the way it's implemented...

Comment 3

[Amarendra Hanumanula]

I see the problem. Thats not the way its suppose to render. Confirming the bug 
and changing the component to style system

Comment 4

[Amarendra Hanumanula]

testcase should show only one 100px height rectangular box with 1px solid lime 
border. But I see two 100px height rect boxes on branch builds: 
2002-08-01-08-1.0 on WIN2K. 

Comment 5

[Boris Zbarsky [:bzbarsky]]

How about reassigning this too?  ;)

The problem is just that style is applied to the anonymous content inside the
<marquee>... Shouldn't XBL prevent that from happening?  I seem to recall there
being something in place for that...

Comment 6

[David Hyatt]

Are you wanting to stop rules in author sheets from applying, or are you wanting to actually cut off CSS inheritance of properties like font and color?  XBL can do the former, but does not have any mechanism for the latter.

Comment 7

[Boris Zbarsky [:bzbarsky]]

I think in this case preventing author rules from applying is what we need.

Comment 8

[jsp]

The URL is now a 404.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Attachment: Simple testcase

Comment 10

[Boris Zbarsky [:bzbarsky]]

Attachment: Equally simple fix

Comment 11

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 138821 [details] [diff] [review]
Equally simple fix

David, would you review?  I'll fix up the tab in the second hunk before
checking in.

Comment 12

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 138821 [details] [diff] [review]
Equally simple fix

Properties still inherit to the real content, right?  Just not the anonymous
content?  If so (test that 'color' still works, when inherited), r+sr=dbaron.

Comment 13

[Boris Zbarsky [:bzbarsky]]

Yeah, that still works.  And document rules still apply to the real content.

"inheritstyle" is really pretty badly named...

Comment 14

[Boris Zbarsky [:bzbarsky]]

Fixed.

Comment 15

[Malcolm Rowe]

Comment on attachment 138820 [details]
Simple testcase

Note that IE6/Win shows a top and bottom border on the marquee with this
testcase. Are we aiming for (marquee-)parity with IE?

Comment 16

[David Hyatt]

The current XBL spec has a different name for "inheritstyle."  I agree that the name is bad, and Hixie and 
I have fixed it in the spec.

Comment 17

[Boris Zbarsky [:bzbarsky]]

Malcolm, could you attach a screenshot of what IE shows?

Comment 18

[Doron Rosenberg (IBM)]

screenshot from IE6: http://nexgenmedia.net/IEMarquee.png

Comment 19

[Boris Zbarsky [:bzbarsky]]

Um... so the non-anonymous div in IE is _not_ being scrolled with the text?  Or
what?  Notice that in Mozilla, with my patch, there is a single red border
around the text; but it's shrink-wrapped.

Comment 20

[Doron Rosenberg (IBM)]

The text is moving, just the left and right div borders are never visible.

Comment 21

[Boris Zbarsky [:bzbarsky]]

Right.  So it scrolls the text, but it's not clear what it's doing with the div.
 I don't think we care, really.