160595 - enter_bug.cgi does not show description of products that start with _

Status: RESOLVED WORKSFORME

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Paul Baker]

This is similar to bug#160557. The enter_bug.cgi screen does not display the
description of products that start with _. This also affects
describecomponents.cgi as it shares the same code and template as enter_bug.cgi.

I am working on the patch for this bug and will attach it very soon.

Comment 1

[Paul Baker]

Attachment: pass arrays instead of hashes to TT

This fixes the problem on my bugzilla installation.

Comment 2

[Paul Baker]

This should be all good to go if someone wants to review it.

Comment 3

[Bradley Baetz (:bbaetz)]

And, similar to bug 160557, I'm not convinced that this is a good idea.

Comment 4

[Vlad Dascalu]

> This should be all good to go if someone wants to review it.

If you want someone to review it you should request this now by setting a
review+ flag next to your attachment.

Comment 5

[Frédéric Buclin]

Attachment: patch, v1

I redefine .item() to accept keys starting with an underscore. Both products
and classifications choosers are affected.

Comment 6

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 187236 [details] [diff] [review]
patch, v1

>+$Template::Stash::HASH_OPS->{ item } =
>+  sub {
>+      return $_[0]->{$_[1]};
>+  };
>+

According to a TT mailing list post from the author of TT, this is the
preferred solution to the problem right now.

http://www.template-toolkit.org/pipermail/templates/2004-January/005556.html

This solution is good for now, but ultimately we should hack TT, adding a
configuration option to turn off TT's feature for hiding hash keys, since we
don't use it, and it hurts us.


>+    [% IF proddesc.item("$p") %]
>+      <td valign="top">&nbsp;[% proddesc.item("$p") FILTER none %]</td>

These should be able to be just proddesc.item(p).

Are there any other uses of these (or other) hashes that need a similar fix?

Comment 7

[Frédéric Buclin]

As long as TT doesn't have a param to force him to display _private keys, I don't see what I could do here...

Comment 8

[Frédéric Buclin]

I cannot reproduce this issue in Bugzilla 3.4 and newer.