160824 - Crash when scrolling [nsTimerImpl::Fire] [@ nsRepeatService::Notify]

Status: VERIFIED FIXED

(Core :: Layout, defect)

Description

[Jure Repinc (JLP)]

In todays build I notice that Mozilla (using 2002080218) crashes a lot when scrolling pages. Windows say that it crashes in module gklayout.dll. It crashes when scrolling for whole page or just a bit of page. I also sent two reprts using Talkback. Their IDs are: TB8936955X and TB8937223Z. This crash didn appear in yesterdays build.

Reproducable: Always

Steps to reproduce
1. Open http://www.slo-tech.com/
2. try to scroll page

Results:
Mozilla crashes

Expected:
Mozilla just scrolls the page normally

Comment 1

[Jo Hermans]

dcone backed out some code tonight (08/02/2002 11:21), this must be related.

"Backing out changes for the background speedup.. it broke some hoovering code..
on a web page. I want to investigate this before I leave the patch in."

Eh ... wait for tomorrow, or try the very latest build from 08/02 (the last one
is from midnight, after the backout).

Comment 2

[R.K.Aa.]

I crash when scrolling on Linux with - fresh CVS, in timer related code.
Perhaps the fix for bug 157123 is a more likely candidate. 

#0  0x416f1bbf in nsRepeatService::Notify () from libgklayout.so
#1  0x40170dbf in nsTimerImpl::Fire () from libxpcom.so
#2  0x40170ef6 in handleTimerEvent () from libxpcom.so
#3  0x4016c8c3 in PL_HandleEvent () from libxpcom.so
#4  0x4016c7bd in PL_ProcessPendingEvents () from libxpcom.so
#5  0x4016d81b in nsEventQueueImpl::ProcessPendingEvents () from libxpcom.so
#6  0x40650506 in event_processor_callback () from /libwidget_gtk.so
#7  0x40650268 in our_gdk_io_invoke () from libwidget_gtk.so
#8  0x4038d9ca in g_io_add_watch () from /usr/lib/libglib-1.2.so.0
#9  0x4038efa5 in g_get_current_time () from /usr/lib/libglib-1.2.so.0
#10 0x4038f5a9 in g_get_current_time () from /usr/lib/libglib-1.2.so.0
#11 0x4038f738 in g_main_run () from /usr/lib/libglib-1.2.so.0
#12 0x402ac297 in gtk_main () from /usr/lib/libgtk-1.2.so.0
#13 0x4065093d in nsAppShell::Run () from libwidget_gtk.so
#14 0x40635496 in nsAppShellService::Run () from libnsappshell.so
#15 0x08052de3 in main1 ()
#16 0x0805368d in main ()
#17 0x42017589 in __libc_start_main () from /lib/i686/libc.so.6
(gdb)

Comment 3

[R.K.Aa.]

seems i can scroll with keys OK. The crash happens shortly after scrolling bu
clicking/dragging scrollbar arrows or thumb/slider

Comment 4

[R.K.Aa.]

adding sfraser to CC. Backing out the fix for bug 156953 (timer changes and
changes to nsSliderFrame.h) cures the crash.

Comment 5

[R.K.Aa.]

TYPO: backing out fix for bug 157123 cures the crash

Comment 6

[R.K.Aa.]

*** Bug 160838 has been marked as a duplicate of this bug. ***

Comment 7

[Gérard Talbot]

I crash 100% of the time when I click the xul:slider of a <div> while using
build 2002080218 on Windows XP Pro.

Comment 8

[Gérard Talbot]

I filed bug 160855 and comment 7 should go there. I didn't know for sure if bug
160824 was related to the crash that clicking on xul:slider of the scrollbar of
a <p>.

Comment 9

[R.K.Aa.]

*** Bug 160855 has been marked as a duplicate of this bug. ***

Comment 10

[Asa Dotzler [:asa]]

dcone, is this you?

Comment 11

[Asa Dotzler [:asa]]

oops, sfraser, according to Kristin's backout test. 

Comment 12

[Asa Dotzler [:asa]]

I've asked that bug 157123 be backed out so this should go away and can be
resolved as fixed as soon as the backout is complete and the resulting builds
are tested.
(note this needs to be backed out on trunk and branch) 

Comment 13

[Christian :Biesinger (don't email me, ping me on IRC)]

bug 157123 is now backed out of both trunk and branch. 

Comment 14

[Felix Miata]

2002080308 trunk for OS/2 produces this trap:

08-03-2002  21:44:49  SYS3175  PID 013f  TID 0001  Slot 0075
H:\MOZILLA\BIN\MOZILLA.EXE
c0000005
1d604709
P1=00000001  P2=00000000  P3=XXXXXXXX  P4=XXXXXXXX  
EAX=00000000  EBX=00e89ed8  ECX=1d8253b4  EDX=00000032
ESI=0029d598  EDI=0965cd19  
DS=0053  DSACC=f0f3  DSLIM=ffffffff  
ES=0053  ESACC=f0f3  ESLIM=ffffffff  
FS=150b  FSACC=00f3  FSLIM=00000030
GS=0000  GSACC=****  GSLIM=********
CS:EIP=005b:1d604709  CSACC=f0df  CSLIM=ffffffff
SS:ESP=0053:00131940  SSACC=f0f3  SSLIM=ffffffff
EBP=00131978  FLG=00012202

GKHTML.DLL 0001:000e4709

Comment 15

[Simon Fraser [no longer active]]

Did anyone check whether the branch crashes before backing out there? A
different patch was checked into the branch that only changed the timer interval
for Mac. None of the crash reports here seem to be for Mac, and none on the branch.

Comment 16

[Simon Fraser [no longer active]]

The simpler, branch-only patch in bug 157123 has been recommitted on the branch,
and checked into the trunk (with a=asa). I filed bug 160926 to clean up the
timer usage. Marking fixed.

Comment 17

[R.K.Aa.]

*** Bug 160986 has been marked as a duplicate of this bug. ***

Comment 18

[R.K.Aa.]

*** Bug 160997 has been marked as a duplicate of this bug. ***

Comment 19

[ly nguyen]

adding stack signature in summary for talkback tracking

Comment 20

[greer]

Talkback tracking also requires the topcrash keyword. Adding it. 

Comment 21

[greer]

*** Bug 161202 has been marked as a duplicate of this bug. ***

Comment 22

[greer]

Talkback data shows this one stopped following Simon's 8/3 patch.
Marking verified.