160927 - "Customize Tab" breaks with JavaScript error

Status: RESOLVED FIXED

(SeaMonkey :: Sidebar, defect)

Description

[James Ross]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.1b) Gecko/20020803
BuildID:    2002080308

Trying to customize a sidebar tab (clicking "Customize Tab" after selecting a
customizable tab) simply results in a JavaScript error.

Reproducible: Always
Steps to Reproduce:
1. Open JavaScript Console (from "Tools" menu, under "Web Developement").
2. Make sure "Show JavaScript errors and warnings in Mozilla chrome" is turned
on in "Debug" in Preference.
3. Open "Customize Sidebar" window (from "Tabs" drop-down above sidebar).
4. Select a tab in the "Tabs in Sidebar" list that allows customization.
5. Click "Customize Tab".

Actual Results:  A JavaScript error is printed to the JS console.

Expected Results:  The Customize Tab window should open.

The JavaScript error generated is:

Error: tree.selectedItems has no properties
Source File: chrome://communicator/content/sidebar/customize.js
Line: 437

Comment 1

[James Ross]

Increasing priority - this is a serious bug - and it's still in 1.2 alpha.

Comment 2

[Andrew Schultz]

how is this "useless-UI"?  Do you see this with a clean profile?

Comment 3

[James Ross]

To quote the page describing Bugzilla keywords:

useless-UI: "Use this keyword when the UI exposes a feature that is either
unusably broken or not implemented."

This feature is entirely broken, so I think it needs the keyword to indicate
this. And yes, it happens on a new profile, on a clean install of Moz 1.2 alpha too.

Comment 4

[James Ross]

If you need a tab to test this with, use the following:

javascript:window.sidebar.addPanel('CompSoc',
'http://www.warwickcompsoc.co.uk/tools/sidebar',
'http://www.warwickcompsoc.co.uk/tools/sidebar?content=customise');

Comment 5

[David G King]

*** Bug 162907 has been marked as a duplicate of this bug. ***

Comment 6

[David G King]

Bug #162907 is a dup of this one, however,
http://bugzilla.mozilla.org/show_bug.cgi?id=162907#c1 is a rather interesting
comment from that bug.

Confirming.

Comment 7

[James Ross]

If it is just the case of not upgrading the JavaScirpt when the new tree API
came about, can we not fix this really easily? (assuming someone has time, I
guess...)

Comment 8

[James Ross]

Attachment: Quick patch to fix JavaScript error.

Comment 9

[James Ross]

Attachment: cvs diff -u version

Comment 10

[James Ross]

Adding nscatfood since this is (or at least should be) important to the Netscape
people, and does have a patch ready for review.

Comment 11

[Jan Varga [:janv]]

how about:
var numSelected = tree.treeBoxObject.selection ?
tree.treeBoxObject.selection.count : 0

other than that r=varga

Comment 12

[James Ross]

Hmm, shouldn't |tree.treeBoxObject.selection.count| be zero if there's no selection?

Comment 13

[Jan Varga [:janv]]

Just following the style in that file.
tree.treeBoxObject.selection can be null, btw

Comment 14

[James Ross]

Attachment: Updates based on Jan's comments.

Comment 15

[Jan Varga [:janv]]

Comment on attachment 106789 [details] [diff] [review]
Updates based on Jan's comments.

r=varga

Comment 16

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 106789 [details] [diff] [review]
Updates based on Jan's comments.

checked in

Comment 17

[Christian :Biesinger (don't email me, ping me on IRC)]

fixed