Closed
Bug 160939
Opened 23 years ago
Closed 21 years ago
printPreviewProgress.js has ugly js that reimplements a xul attribute
Categories
(Core :: Print Preview, defect, P3)
Core
Print Preview
Tracking
()
RESOLVED
FIXED
People
(Reporter: wolruf, Assigned: neil)
References
()
Details
Attachments
(2 files)
|
534 bytes,
patch
|
Details | Diff | Splinter Review | |
|
3.70 KB,
patch
|
timeless
:
review+
alecf
:
superreview+
|
Details | Diff | Splinter Review |
build ID: 20020730 (trunk) on Linux.
JavaScript strict warning:
chrome://global/content/printPreviewProgress.js line 52: redeclaration of var str
|
Reporter | |
Comment 1•23 years ago
|
||
|
|
Reporter | |
Updated•23 years ago
|
um, interesting patch, but i'd prefer for the entire function to be deleted.
rods: please use the crop attribute.
|
||
Comment 3•23 years ago
|
||
not familar with the "crop" attr, please point me to somewhere
|
|
Reporter | |
Comment 4•23 years ago
|
||
Found this via Google:
http://www.mozilla.org/xpfe/xulref/button.html#crop
|
||
Updated•22 years ago
|
Priority: -- → P3
Target Milestone: --- → Future
|
|
Reporter | |
Comment 5•21 years ago
|
||
marking dupe since bug 228529 has patch.
*** This bug has been marked as a duplicate of 228529 ***
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → DUPLICATE
nah, i still want the right thing done. i was just annoyed by 1.6b...
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Assignee: rods → neil.parkwaycc.co.uk
Status: REOPENED → NEW
OS: Linux → All
Hardware: PC → All
Target Milestone: Future → ---
|
Assignee | |
Comment 7•21 years ago
|
||
I couldn't generate many progress notifications but we have back-end code to
ignore attribute unchanges so I removed the equivalent code here.
|
|
Assignee | |
Updated•21 years ago
|
Attachment #137454 -
Flags: review?(timeless)
Comment on attachment 137454 [details] [diff] [review]
Proposed patch
looks good, but somehow i doubt it applies today :)
Attachment #137454 -
Flags: review?(timeless) → review+
|
|
Assignee | |
Comment 9•21 years ago
|
||
Comment on attachment 137454 [details] [diff] [review]
Proposed patch
I don't know why timeless, thought the patch wouldn't apply, the js is only on
1.4 now as it is, while the xul is the still the original 1.1 ...
Attachment #137454 -
Flags: superreview?(alecf)
|
||
Comment 10•21 years ago
|
||
Comment on attachment 137454 [details] [diff] [review]
Proposed patch
hey if this works, sr=alecf
Attachment #137454 -
Flags: superreview?(alecf) → superreview+
|
|
Assignee | |
Comment 11•21 years ago
|
||
Comment on attachment 137454 [details] [diff] [review]
Proposed patch
Oh I see, someone patched 1.3, so I have to back that out first ;-)
|
|
Assignee | |
Comment 12•21 years ago
|
||
Fix checked in.
Status: NEW → RESOLVED
Closed: 21 years ago → 21 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•