160973 - gtk assertion on installer exit from auto-mode

Status: RESOLVED FIXED

(SeaMonkey :: Installer, defect)

Description

[Andrew Schultz]

When the running the installer in auto-mode (./mozilla-installer -ma), this
message appears in my console when it finishes:

Gtk-CRITICAL **: file gtkmain.c: line 582 (gtk_main_quit): assertion `main_loops
!= NULL' failed.

Comment 1

[Andrew Schultz]

Attachment: patch2

normal mode fires off gtk_main() to run the wizard.  auto mode does not.
the gtk_main_quit() in ShowCompleteDlg() actually corresponds to that
gtk_main() and should not be called for the auto mode.

Closing out the wizard seems like something that should be done quite a bit
upstream.  I moved it to PerformInstall(), although it could probably go up
farther.

Comment 2

[Andrew Schultz]

reassign

Comment 3

[Andrew Schultz]

Comment on attachment 107671 [details] [diff] [review]
patch2

still looking for review-love

Comment 4

[Andrew Schultz]

-> me

Comment 5

[Alexander Opitz]

Andrew: Do you work on linux installer bugs? Does this patch work in newer builds?

Comment 6

[Andrew Schultz]

Attachment: patch3

this implements my own suggestion about moving gtk_main_quit farther upstream. 


This patch just removes gtk_main_quit from ShowCompleteDlg and the check for
bDLCancel (set when the download is cancelled).  The check seems totally bogus
because gtk_main is not called in relation to downloading the XPIs.  

I tested both normal and auto mode for the cases of:
1. cancelling the download
2. not cancelling the download
3. having the XPIs already downloaded

all 6 tests were successful and no assertions.

Comment 7

[Andrew Schultz]

> Andrew: Do you work on linux installer bugs?

if they're relatively simple.  but someone has to review them.

Comment 8

[Daniel Veditz [:dveditz] out until Nov 10]

Comment on attachment 140211 [details] [diff] [review]
patch3

r=dveditz

Comment 9

[Andrew Schultz]

Comment on attachment 140211 [details] [diff] [review]
patch3

thanks dveditz!
looking for more review-love.

Comment 10

[Andrew Schultz]

biesi: can you check in this patch?
thanks!

Comment 11

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in nsInstallDlg.cpp;
/cvsroot/mozilla/xpinstall/wizard/unix/src2/nsInstallDlg.cpp,v  <-- 
nsInstallDlg.cpp
new revision: 1.27; previous revision: 1.26
done