161138 - Default/null plugin downloads embedded content anyway.

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect, P3)

Description

[Adam D. Moss]

When visiting a page with embedded content without the appropriate
plugin, the default plugin puts up its 'you don't have the right
plugin to view blah/blah data' dialog.  Which is fine.  I hit 'cancel'.
But the embedded content itself keeps coming down the pipe as long
as I have the offending page open somewhere, like in another tab.
Big fat content.  Saturating my little pipe with data I can't see,
and prob'ly evicting some useful stuff from my cache for all I know.

Maybe the default/null plugin just needs to explicitly kill the
incoming stream's connection when I hit 'cancel' (or as soon as it
is invoked, since the odds are probably against a user really
going and bothering to get the plugin, coming back to the page
and having the content all toasty-warm in the cache, since I suspect
that most times the default/null plugin hits someone's eyes is if
they're a recalcitrant embedded-content-ignorer like me).

This is with Mozilla 1.0.  IIRC this happens with CVS-HEAD but
my trunk build hangs on startup at the moment so I can't verify
that right now.

Comment 1

[rubydoo123]

this will be addressed with the plug-in manager work

Comment 2

[Adam D. Moss]

FYI I've just verified that this does indeed occur on CVS HEAD.

Comment 3

[ow]

> When visiting a page with embedded content without the appropriate
> plugin, the default plugin puts up its 'you don't have the right
> plugin to view blah/blah data' dialog.  Which is fine.  I hit 'cancel'.

Actually, I am looking for a way to disable this "Default plugin missing"
message completely. I removed the Flash plugin, I know I do not have it, it
would be GREAT if there was a way to suspend this message.It could be a (new)
config setting in Edit->Preferences. Thanks

Comment 4

[Peter Lubczynski]

Attachment: possible fix?

Comment 5

[Adam D. Moss]

That looks pretty good to me (haven't tried it though)!

Comment 6

[serge (gone)]

Comment on attachment 106629 [details] [diff] [review]
possible fix?

that's exactly what we are doing on win32
http://lxr.mozilla.org/seamonkey/source/modules/plugin/samples/default/windows/
npshell.cpp#244

Comment 7

[rubydoo123]

moving to plug-in branch work

Comment 8

[Philip K. Warren]

Attachment: UNIX patch

This is the same as the previous fix, but uses C comments instead of C++
comments. I left out the change to the Mac default plugin since someone who has
a Mac should test that change.

Comment 9

[Christopher Blizzard (:blizzard)]

Comment on attachment 141847 [details] [diff] [review]
UNIX patch

sr=blizzard Looks good from where I'm sitting.

Comment 10

[Philip K. Warren]

Fixed.

Checking in npshell.c;
/cvsroot/mozilla/modules/plugin/samples/default/unix/npshell.c,v  <--  npshell.c
new revision: 1.17; previous revision: 1.16
done