161226 - extensibility hooks for mailnews FE, and IMAP back end.

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[(not reading, please use [e-mail] instead)]

extensibility hooks for mailnews FE, and IMAP back end.

tracker bug to land some work bienvenu and I are doing.

Comment 1

[David :Bienvenu]

Attachment: some backend db changes to expose api's

this exposes some more backend functionality to the front end js code...

Comment 2

[(not reading, please use [e-mail] instead)]

Comment on attachment 94271 [details] [diff] [review]
some backend db changes to expose api's

sr=sspitzer

Comment 3

[Cavin Song]

Comment on attachment 94271 [details] [diff] [review]
some backend db changes to expose api's

r=cavin.

Comment 4

[David :Bienvenu]

first patch checked in.

Comment 5

[John Morrison]

I was looking at http://climate/ for talkback data on a different bug, but I 
happened to notice that, in builds of 08/07, there are couple of new top crashes
occurring in mork code called from nsMsgDatabase::InitNewDB(). You might want 
to check whether those are related to these changes.

Comment 6

[David :Bienvenu]

that was a corrupt build from the release team as a result of switching to gmake
but not building dependencies - it has absolutely nothing to do with this checkin.

Comment 7

[John Morrison]

Ah. Sorry. Nevermind.

Comment 8

[David :Bienvenu]

well, I should say that this checkin did expose the dependency problem :-)

Comment 9

[David :Bienvenu]

Attachment: add OnEndMsgDownloaded notification

add a notification when Mime has finished downloading a message.

Comment 10

[David :Bienvenu]

JF, can I get an r= for the mime changes (the add OnEndMsgDownloaded
notification) patch? thx.

Comment 11

[Jean-Francois Ducarroz]

Comment on attachment 94954 [details] [diff] [review]
add OnEndMsgDownloaded notification

R=ducarroz

Comment 12

[David :Bienvenu]

Attachment: more extensibility hooks, mostly for imap stuff

these mostly add the ability to run custom imap commands and fetch custom imap
attributes - there are also hooks to know when a msg hdr has been downloaded,
and support for custom keywords.

Comment 13

[David :Bienvenu]

Cavin, can I get an r= for the third patch, the "more extensibility hooks" one? thx.

Comment 14

[(not reading, please use [e-mail] instead)]

Comment on attachment 94271 [details] [diff] [review]
some backend db changes to expose api's

sr=sspitzer

Comment 15

[(not reading, please use [e-mail] instead)]

Comment on attachment 94954 [details] [diff] [review]
add OnEndMsgDownloaded notification

sr=sspitzer

Comment 16

[Cavin Song]

Comment on attachment 94968 [details] [diff] [review]
more extensibility hooks, mostly for imap stuff

r=cavin. Looks good and I only see a tabbing issue in
nsImapFlagAndUidState::GetCustomFlags().

Comment 17

[David :Bienvenu]

Attachment: patches to clean up some js exceptions

this patch cleans up some js exceptions that the other patches caused. Cavin,
can you review? thx.

Comment 18

[(not reading, please use [e-mail] instead)]

Comment on attachment 94968 [details] [diff] [review]
more extensibility hooks, mostly for imap stuff

sr=sspitzer

Comment 19

[(not reading, please use [e-mail] instead)]

Comment on attachment 94998 [details] [diff] [review]
patches to clean up some js exceptions

sr=sspitzer

Comment 20

[(not reading, please use [e-mail] instead)]

Attachment: FE patch, not ready for review yet...

Comment 21

[(not reading, please use [e-mail] instead)]

Attachment: mail FE changes + themes changes.

note, still not ready for reviews.

Comment 22

[(not reading, please use [e-mail] instead)]

Attachment: more changes, not ready for review...

Comment 23

[(not reading, please use [e-mail] instead)]

Attachment: patch, fix commandglue.js to use redirector based pref

Comment 24

[David :Bienvenu]

Comment on attachment 95232 [details] [diff] [review]
patch, fix commandglue.js to use redirector based pref

sr=bienvenu - there's a tab here, I think:
+		    var m

and I coulda sworn I'd already checked in a couple of these changes (the ones
to msgHdrViewOverlay.js), but it all looks fine.

Comment 25

[(not reading, please use [e-mail] instead)]

they aren't up yet, but see http://www.mozilla.org/mailnews/arch/index.html for 
links to documents about how to use these folder pane, message pane, thread 
pane, compose window, mail window extras.

Comment 26

[(not reading, please use [e-mail] instead)]

fixed.  any other issues will be spun up as new bugs.

Comment 27

[[e-mail]]

Comment on attachment 95232 [details] [diff] [review]
patch, fix commandglue.js to use redirector based pref

> // what if I have two rows selected, and I hit delete, and so we load the next row.
> // what if I have commands that only enable where exactly one row is selected?

Well, in the IMAP delete model nothing happens when you delete multiple rows. A
pity that's not an option for other models.

Comment 28

[[e-mail]]

Comment on attachment 95232 [details] [diff] [review]
patch, fix commandglue.js to use redirector based pref

> // you might not have a db view.  this can happen if
> // biff fires when the 3 pane is set to account central.
> if (!gDBView)
>   return;
> gDBView.onDeleteCompleted(true);

Do you want to call onDeleteCompleted when gDBView doesn't refer to the
specified folder?

Comment 29

[Greg K.]

Did this break third-party themes? See
[news://news.mozilla.org/[e-mail]].

Comment 30

[Tim]

One of these patches has caused bug 162981. I confirmed this by backing out the
following checkins:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=SeaMonkeyAll&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=08%2F14%2F2002+15%3A10&maxdate=08%2F14%2F2002+15%3A20&cvsroot=%2Fcvsroot

(I'm guessing this is attachment 95232 [details] [diff] [review], but I haven't checked)

After those checkins are reversed (with some hand-holding for a single
conflict), Mail/news once again loads with third-party themes with the XUL cache
enabled (the problem mentioned in bug 162981 does not occur if the XUL cache is
disabled).

Comment 31

[Tim]

SPAM: sorry for the spam. Just clarifying that the bug number is 162891 (I
transposed 8 and 9 two times... oops).

Comment 32

[[e-mail]]

Comment on attachment 95232 [details] [diff] [review]
patch, fix commandglue.js to use redirector based pref

In (I think) ChangeFolderByUri why are there two sets of updates, one at the
beginning and one at the end (which doesn't get called for Account Central;
note that this bug affects SetUpToolbarButtons!)

Comment 33

[Alfred Kayser]

I've created bugreport 163837, to address the real issue
behing the problem with missing .css files in theme files.

Comment 34

[Daniel Veditz [:dveditz]]

Please add the adt1.0.2 keyword when a branch patch is ready

Comment 35

[(not reading, please use [e-mail] instead)]

the fix for this bug has landed on the trunk and the branch.

Comment 36

[laurel]

verified on commercial branch and commercial trunk.