161383 - Checkmark indicating active window in Window menu only shows on second menu access

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Greg K.]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:1.1b) Gecko/20020805
BuildID:    2002080508

The checkmark that's supposed to display in front of the name of the active
window in the Window menu doesn't display until the second time the menu is
accessed.

Reproducible: Always
Steps to Reproduce:
1. Launch Mozilla to display one Navigator window
2. Access the Window menu

Actual Results:  The checkmark is not displayed in front of window 1's listing
on the Window menu.

Expected Results:  The checkmark should have been displayed in front of window
1's listing on the Window menu.

The checkmark displays the second time the Window menu is accessed.

Comment 1

[Greg K.]

Bug 144622 may be caused by the same underlying problem.

Comment 2

[Jim Laurent]

I'm also using Moz 1.5 RC2 on OS X and find times when 4 out of 5 windows have
the checkmark in front of them in the Window menu.

checkmarks appear without rhyme or reason.

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.5) Gecko/20030925

Comment 3

[Don Crandall]

changing onpopupshown to onpopupshowing solves the menu upadate problem in my
testing.

Patch forthcoming.

Comment 4

[Don Crandall]

Attachment: changes onpopupshown to onpopupshowing

Comment 5

[Greg K.]

Reassigning to patch author.

Comment 6

[Greg K.]

Comment on attachment 140356 [details] [diff] [review]
changes onpopupshown to onpopupshowing

Adding review?[e-mail].

Comment 7

[Greg K.]

Requesting blocking1.7. Has patch needing review.

Comment 8

[Greg K.]

Simon or pink, might one of you be able to review this patch?

Comment 9

[Asa Dotzler [:asa]]

this impacts both seamonkey and firefox (and probably thunderbird as well).
Bryner, can you take a look at this patch? It looks trivial to my untrained eye. 

Comment 10

[[e-mail]]

Comment on attachment 140356 [details] [diff] [review]
changes onpopupshown to onpopupshowing

Looks like the mac native menu is built in between the popupshowing and
popupshown event so that no changes in the popupshown event will take effect.

Comment 11

[Asa Dotzler [:asa]]

Comment on attachment 140356 [details] [diff] [review]
changes onpopupshown to onpopupshowing

a=asa (on behalf of drivers) for checkin to 1.7

Comment 12

[Mike Calmus]

Just confirming that this now works with a CVS HEAD build.

Comment 13

[Mike Kaply [:mkaply]]

Why is this bug still open?

Comment 14

[Greg K.]

Who checked this in? roc? neil?

Comment 15

[[e-mail]]

Yes, I checked it in 9 days ago, sorry for not resolving this bug.